Sage / omniauth-cognito-idp

OmniAuth Strategy for AWS Cognito in Ruby
Apache License 2.0
35 stars 13 forks source link

Devise OmniAuth compatibility #12

Closed 3zcurdia closed 1 year ago

3zcurdia commented 1 year ago

This PR aims to resolve an integration issue between your gem and OmniAuth 2 within the Devise ecosystem. The current problem arises from the strategy name not being properly normalized, resulting in conflicts that skip the middleware. Additionally, there is an issue with the on_auth_path? method from the OmniAuth strategy not matching under Devise configurations. Let's delve into these points in more detail for improved clarity and readability.

To address this issue, the proposed solution involves renaming the strategy to match the expected methods from Devise's OmniAuth callbacks controller.

jkintscher commented 1 year ago

This would also close https://github.com/Sage/omniauth-cognito-idp/issues/8

We are experiencing the same problem and currently have to use this patch directly. Is there someone who can review this PR and potentially release it as a new version?

3zcurdia commented 1 year ago

Closing this issue, because it seems like an abandoned project