search

Sage / omniauth-cognito-idp

OmniAuth Strategy for AWS Cognito in Ruby
Apache License 2.0
35 stars 13 forks source link

Rename the 'name' to 'cognito_idp' (Use underscore instead of hyphen), easier connect with Rails/Devise #8

Open ash-r1 opened 3 years ago

ash-r1 commented 3 years ago

I'm using this gem with devise-omniauthable on Ruby on Rails. It implicitly uses its name option field in rails routing.

I have to configure with like below:

config.omniauth :cognito_idp,
  name: :cognito_idp,
  # other options

I know it's not bad of omniauth-cognito-idp, it's just a compatibility issue. They can also fix this issue. But it might not cause any problem for Sinatra users, also I believe I achieve benefits for Rails users, please consider this change.