Node v14 support - Githubissues

Sage / streamlinejs

Asynchronous JavaScript for dummies

http://bjouhier.wordpress.com/2011/01/09/asynchronous-javascript-the-tale-of-harry/

MIT License

959 stars 56 forks source link

Node v14 support #383

Closed bcko closed 4 years ago

bcko commented 4 years ago

This pull request supports Node v14 by using recently published streamline-runtime v3.0.0.

updated streamline-runtime to recently published v3.0.0
added node 14 to travis.yml

related issue: streamline-runtime and fibers 5.x https://github.com/Sage/streamlinejs/issues/382 related pull request: Node v14 support. Fibers v5.0.0 support https://github.com/Sage/streamline-runtime/pull/11

cc: @bjouhier

bcko commented 4 years ago

@bjouhier I was not sure what your Node support policy was so I didn't deprecate Node 8 in this pull request. Let me know if you want me to modify the pull request to deprecate Node 8. Thank you!

bcko commented 4 years ago

@bjouhier I hope you had a good weekend. Just wanted to say hi and was wondering if there is anything I can do to get this pull request merged. Thank you!

bjouhier commented 4 years ago

Hi @bcko Sorry for the delay. I approved it this morning and published streamline@4.0 to NPM. Thanks

bcko commented 4 years ago

No worries at all! Thank you for pull request review and thank you for publishing to NPM!