Update to Graph Theory / Isomorphism Chapter

[boughrira]

• Clean up (whitespace, indentation, and Sage code reformat)
• Minor update to the Isomorphism section: refactor Python code, minor clean up (whitespace & indentation)

Link to changes in the printed version

[Samuel-Lubliner]

Thanks for reformatting the code! I agree the style is much better.

Yes Sage is built on Python, but the function is still Sage, not Python.

vscode ➜ /workspaces/sage-discrete-math (update-graph-theory-chapter) $ pretext build
Generated `/workspaces/sage-discrete-math/codechat_config.yaml`

Generated `/workspaces/sage-discrete-math/requirements.txt`

PreTeXt-CLI version: 2.5.2

PreTeXt project found in `/workspaces/sage-discrete-math`.
Since no target was supplied, we will use "web".

Building target web
Preparing to build into /workspaces/sage-discrete-math/output/web.
discovering source file's directory name: /workspaces/sage-discrete-math/source
verifying and expanding input directory: /workspaces/sage-discrete-math/source/../generated-assets
input directory expanded to absolute path: /workspaces/sage-discrete-math/generated-assets
verifying and expanding input directory: /workspaces/sage-discrete-math/source/../assets
input directory expanded to absolute path: /workspaces/sage-discrete-math/assets
Runestone Services (via PreTeXt repository): version 7.3.0
Runestone Services (using newer, via online CDN query): version 7.4.0
converting /workspaces/sage-discrete-math/source/main.ptx to HTML in /tmp/ptx-vw8nfmdm
XSL conversion of /workspaces/sage-discrete-math/source/main.ptx by /home/vscode/.ptx/2.5.2/core/xsl/pretext-html.xsl
messages from the log for XSL processing:
warning: * PTX:WARNING: There are apparent XML elements in locations that should be text only (1 times).
warning: * PTX:WARNING: There is an apparent XML element (<pre>) inside an <input> element, which should only contain text.  Using an escaped "less than" ('&lt;') might be the solution, or using a CDATA section.
*              located within: "isomorphism" (xml:id), "Isomorphism" (title)
successful application of /home/vscode/.ptx/2.5.2/core/xsl/pretext-html.xsl

Success! Run `pretext view` to see the results.

I think we should remove <pre language="python">

[boughrira]

@Samuel-Lubliner I will wait on a second approval for #116 and #117 PRs into merge them to this branch, and make the change you suggested (remove the <pre> block) and resubmit for review.

I have another WIP branch to set up the pre-commit git hook so that the code is formatted on commit (remove trailing spaces and enforce the LF newLine character, ...etc.), and will run it on the repo files (without any edits to the content). Once merged, the hook will take care of XML-styling so that the code is consistent (for and from all contributors).

cc: @Zune-Ahmed @hcolmanccc

[Zune-Ahmed]

Reviewed and approved, good catches

Zunaid

---

From: Allaoua @.> Sent: Monday, September 2, 2024 4:59:12 PM To: SageMathOER-CCC/sage-discrete-math @.> Cc: Zunaid Ahmed @.>; Mention @.> Subject: Re: [SageMathOER-CCC/sage-discrete-math] Update to Graph Theory / Isomorphism Chapter (PR #115)

@Samuel-Lublinerhttps://github.com/Samuel-Lubliner I will wait on a second approval for #116https://github.com/SageMathOER-CCC/sage-discrete-math/pull/116 and #117https://github.com/SageMathOER-CCC/sage-discrete-math/pull/117 PRs into merge them to this branch, and make the change you suggested (remove the

 block) and resubmit for review.

I have another WIP branch to set up the pre-commit git hook so that the code is formatted on commit (remove trailing spaces and enforce the LF newLine character, ...etc.), and will run it on the repo files (without any edits to the content). Once merged, the hook will take care of XML-styling so that the code is consistent (for and from all contributors).
cc: @Zune-Ahmedhttps://github.com/Zune-Ahmed @hcolmanccchttps://github.com/hcolmanccc
—
Reply to this email directly, view it on GitHubhttps://github.com/SageMathOER-CCC/sage-discrete-math/pull/115#issuecomment-2325331620, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5KWWUX3G5PYUOK6CVICU43ZUTNTBAVCNFSM6AAAAABNPE42ZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGMZTCNRSGA.
You are receiving this because you were mentioned.Message ID: @.***>