SageMathOER-CCC / sage-discrete-math

An open textbook for Discrete Mathematics with SageMath, as taught at the City Colleges of Chicago
https://sagemathoer-ccc.github.io/sage-discrete-math/
Other
2 stars 2 forks source link

Fix pdf workflow #124

Closed Samuel-Lubliner closed 2 weeks ago

Samuel-Lubliner commented 2 weeks ago

This patches the breaking change in the PDF workflow from PR #122

There is no need to manually generate the PDF. The workflow handles it on merge into main. I removed the PDF output from the main branch because this seemed to break the workflow. The PDF output is automatically stored on a sperate branch. https://github.com/SageMathOER-CCC/sage-discrete-math/tree/pdf-update

I implemented it this way because I was having a hard time getting the GitHub actions bot to make changes on the main branch. I think we can allow the bot to make changes on main with a token but the separate branch seemed like a simpler workaround to me.

See the link from the textbook brings you to the branch with the PDF for download.

https://sagemathoer-ccc.github.io/sage-discrete-math/frontmatter-6.html

If you think there is a better way to do it let's try it out! Maybe there is a way we can include the PDF as an asset of the website itself and then we don't need have users come to GitHub to download. Either way it would be nice to keep this process automated.