search

SageMathOER-CCC / sage-discrete-math

An open textbook for Discrete Mathematics with SageMath, as taught at the City Colleges of Chicago
https://sagemathoer-ccc.github.io/sage-discrete-math/
Other
2 stars 2 forks source link

updated according to the peer reviewers #97

Closed Zune-Ahmed closed 2 months ago

Zune-Ahmed commented 3 months ago

Edited according to the feedback we got back, later updated with the new main branch, but doesnt affect the changed I made for chap 3 and 4

hcolmanccc commented 3 months ago

"Building on the concept of truth tables, we can analyze more complex logical expressions involving multiple variables and conditions. "

We can also analyze more complex logical expressions involving multiple variables and conditions.

On Aug 15, 2024, at 12:32 PM, Samuel Lubliner @.***> wrote:

This message is from an external sender. Please do not open unexpected links or attachments.

@Samuel-Lubliner commented on this pull request.

In source/logic/sec-truth-table.ptxhttps://github.com/SageMathOER-CCC/sage-discrete-math/pull/97#discussion_r1718763767:

@@ -34,7 +34,7 @@

SymbolicLogic() creates an instance for handling symbolic logic operations, while statement() defines the given statement. The truthtable() method generates a truth table for this statement, and print_table() displays it.

- Expanding on the concept of truth tables, we can analyze logical expressions involving three variables. This provides a deeper understanding of the interplay between multiple conditions. The truthtable() function accommodates expressions with any reasonable number of variables. + Expanding on the concept of truth tables, we can analyze logical expressions involving three variables. This provides a deeper understanding of the interplay between multiple conditions. The truthtable() function supports expressions with a number of variables that is practical for computational purposes, typically up to a few dozen.

Maybe instead of "Expanding on the concept of truth tables, we can analyze logical expressions involving three variables. This provides a deeper understanding of the interplay between multiple conditions. The truthtable() function supports expressions with a number of variables that is practical for computational purposes, typically up to a few dozen."

We can say something like:

"Building on the concept of truth tables, we can analyze more complex logical expressions involving multiple variables and conditions. The truthtable() function can accept an arbitrary number of variables. However, when the number of variables is large, the table's columns may extend beyond the page width, making it difficult to view the entire table. Additionally, keep in mind that the function's run time increases exponentially as the number of variables grows."

What do you think? @hcolmanccchttps://github.com/hcolmanccc

— Reply to this email directly, view it on GitHubhttps://github.com/SageMathOER-CCC/sage-discrete-math/pull/97#discussion_r1718763767, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFJZLUXODBVWFVKK3JCS4UDZRTQZ3AVCNFSM6AAAAABMLEQGYOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBQHE3DOMBSGA. You are receiving this because you were mentioned.Message ID: @.***>

Hellen Colman, Ph.D. Professor of Mathematics Wilbur Wright College 4300 N. Narragansett Chicago, IL 60634

@.*** hellencolman.com/mathhttps://www.hellencolman.com/math