SagerNet / sing-box

The universal proxy platform
https://sing-box.sagernet.org/
Other
18.25k stars 2.18k forks source link

invalid interface changed events ommited #1017

Closed Mahdi-zarei closed 7 months ago

Mahdi-zarei commented 10 months ago

Operating system

Linux

System version

Ubuntu 22.04.3 LTS (GNU/Linux 5.15.0-86-generic x86_64)

Installation type

Original sing-box Command Line

If you are using a graphical client, please provide the version of the client.

No response

Version

latest dev-next branch, with few unrelated modifications

Description

I have a fork of sing-box, with some changes that do not even come close to sing-tun or interface handling, recently I was detecting some inconsistency in the connections, and after I added a log which gets called when InterfaceUpdated() gets called, I noticed that the InterfaceUpdated() function was getting called repeatedly, my setup is being run on a VM and its network stack setting is completely fixed, so I assume these calls might be made due to a bug regarding interface monitoring.

Reproduction

add a log to InterfaceUpdated() on one of the outbounds that implement it (Hysteria2 does not implement it). Then set up sing-box on a (rather ubuntu) machine on which the network stack does not change. The log will be indicating that the InterfaceUpdated() is getting called despite no changes occurring in the interfaces.

Logs

+0000 2023-10-29 16:23:44 ERROR outbound/trojan[LondonTR]: Mux client closed with err network changed
+0000 2023-10-29 16:23:44 ERROR outbound/trojan[LondonTRWG]: Mux client closed with err network changed
+0000 2023-10-29 16:23:44 ERROR outbound/tuic[LondonT]: Closed client with error network changed
+0000 2023-10-29 16:23:44 ERROR outbound/tuic[LondonTWG]: Closed client with error network changed
+0000 2023-10-29 16:23:57 ERROR outbound/trojan[LondonTR]: Mux client closed with err network changed
+0000 2023-10-29 16:23:57 ERROR outbound/trojan[LondonTRWG]: Mux client closed with err network changed
+0000 2023-10-29 16:23:57 ERROR outbound/tuic[LondonT]: Closed client with error network changed
+0000 2023-10-29 16:23:57 ERROR outbound/tuic[LondonTWG]: Closed client with error network changed
github-actions[bot] commented 7 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days