search

Saghen / blink.cmp

Performant, batteries-included completion plugin for Neovim
MIT License
631 stars 26 forks source link

feat(opt): option to use mini.icons instead of default ones #40

Closed pwnwriter closed 2 days ago

pwnwriter commented 2 days ago

Hi @Saghen,

This PR adds support for using mini icons in the autocomplete menu.

Now, if one uses mini.icons, just enable them inside the config,

use_mini_icons = false by default.

I also added fallback to predefined icons if mini icons are not available.

Testing

Verified mini icons display correctly when enabled. Confirmed fallback icons work as expected.

Screenshot 2024-10-08 at 2 03 29 PM
simifalaye commented 2 days ago

I don't think it is necessary to hardcode support for any specific icon provider but instead, provide an API for using your own icons or a icon provider. You'd just be taking on another dependency that you don't need to and be forced to maintain compatibility between a completely optional integration if its API ever changed. There are other icon providers and there may be some that come in the future; instead of trying to support every one, just provide an API for integration especially since using any icon provider is completely optional.

pwnwriter commented 2 days ago

@simifalaye Makes sense, I'm closing this pr for now!