Sahamati / rahasya

The project aims to simplify the usage of ECC curve (curve25519) with Diffie-Hellman Key exchange. The work is inline with the Account Aggregator Specification.
Apache License 2.0
13 stars 20 forks source link

Updated the DHPublicKey field as per current REBIT spec #11

Closed Formatter closed 4 years ago

Formatter commented 4 years ago

Fixes the current open issue #5

Formatter commented 4 years ago

@vishwa-vyom this is a fix for one of the currently open issues. Also, I believe nonce generation logic can be added to the KeyMaterial as well, so that this service can be usable OOTB. Let me know if you would like me to raise a pull request for the same, thanks.

vishwa-vyom commented 4 years ago

@Formatter Thanks for the contribution, I will discuss with Sasikumar to merge your pull request.

Regarding the Nonce we purposefully avoided since the generated key can be reused till the expiry, but nonce has to be different for every transaction.

Formatter commented 4 years ago

Alright, sounds good. Let me know if there is a new feature request/bug,happy to help out. My startup is building out FIU/FIP modules and this has great boost to our efforts! Thanks for this.