search

SaiChaitanya13 / pe

0 stars 0 forks source link

Budget message shows when I add a transaction in a very old date. #2

Open SaiChaitanya13 opened 1 year ago

SaiChaitanya13 commented 1 year ago

I get the budget message even when I add a transaction from a long time ago. The budget message also tells me to "keep it up!" which does not make sense as this is an old transaction and there is no way I can change my spending now.

image.png

soc-pe-bot commented 1 year ago

Team's Response

This is only an aesthetics issue, and you are also unlikely to delete a transaction from the past to begin with.

"Keep it Up" is intended as a message to ask you to keep up with sticking to your budget for the month you are in now and for the future. We apologise if this message confused you.

An issue was raised from PE-D, when other users want to see the message even for previous/future months. Hence, this is ultimately up to user's preference (https://github.com/AY2223S2-CS2113T-T09-1/tp/issues/307)

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I am sorry but I do not really agree with your reasoning. Sure, users can see the message for previous months which is fine. But it does not make sense that the budget is the same. Furthermore, let's say I added a transaction from the past month (For example, if I forgot to add) The keep it up message still comes up but that does not make sense as something in the past cannot be changed. While this may be an aesthetics issue, the phrasing of the UI for previous months could be changed. Perhaps, something like "You have exceeded your budget for " or "You spent within your budget for ".

I can agree for severity as it can be seen as an aesthetic issue and gives the wrong message to the user. But I believe that the issue still holds true.

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]