SaiUpadhyayula / spring-reddit-clone

Reddit clone built using Spring Boot, Spring Security with JWT Authentication, Spring Data JPA with MySQL, Spring MVC. The frontend is built using Angular - You can find the frontend source code here - https://github.com/SaiUpadhyayula/angular-reddit-clone
658 stars 386 forks source link

Spring already comes with Nimbus JWT library #23

Closed Toerktumlare closed 2 years ago

Toerktumlare commented 3 years ago

https://github.com/SaiUpadhyayula/spring-reddit-clone/blob/bdedc07f2ad419063f57fca9cc7827dce5efd96c/pom.xml#L67

There is no need for an "extra" JWT library, when Nimbus JWT library is already included in spring security.

https://docs.spring.io/spring-security/site/docs/current/reference/html5/#oauth2resourceserver-jwt-decoder-bean

SaiUpadhyayula commented 2 years ago

The issue is addressed as per this commit - https://github.com/SaiUpadhyayula/spring-reddit-clone/commit/66fe28499e3ba64439eb72ffceba059e69a81201

Thanks for creating the issue