Saibot393 / LocknKey

A Foundry VTT module to handle locking and unlocking of doors and other objects
MIT License
10 stars 7 forks source link

Lockpick macro ignoring reliable talent #100

Open Dprime84 opened 5 months ago

Dprime84 commented 5 months ago

Hi, i've been messing about with the lockpick macro and noticed that it ignores the reliable talent flag. Is there any way to address that?

Saibot393 commented 5 months ago

I am afraid you will have to do that manually. To do that, you can go into the lock & key settings of actors prototype token, there you can set "Lockpick formula" setting for that token to max(1d20,10) + @actor.system.abilities.dex.mod + @actor.system.tools.thief.prof.flat + @actor.system.tools.thief.bonus and check the "Override Lockpick formula" setting.

Dprime84 commented 5 months ago

That's exactly what I needed, thank you! Bit of an unrelated question but is there any reason why the pickpocket macro would cause a merchant to stop being interactive? The macro worked correctly and b allowed the player to steal from the merchant but afterwards the npc lost the merchant tag. I put it back in place but the player could no longer interact with that particular token.

Saibot393 commented 5 months ago

Thats strange, i will look into it, i assume that that was a item piles merchant?

Dprime84 commented 5 months ago

Yup. A night hag set up as potion vendor. Strangely enough, the player had the option to pick pocket her claw attack...

Saibot393 commented 5 months ago

Oh, yeah, there is no filter for item types in the pickpocketing. I was planning an adding more options to pickpocketing soon (including type filters and per item dcs), but didn't yet have time to do so.

Dprime84 commented 5 months ago

Ooh those look like features that would be really nice. Anyhow, I think I'll take the pickpocket macro away for now so I don't have this issue.

Saibot393 commented 5 months ago

I can not seem to replicate this bug, could you send me the merchants actor .json export, maybe there is a specific setting that causes this

Dprime84 commented 5 months ago

Got limited access to it right now but I think it might be something to do with the item piles add-on not working correctly with v12

Saibot393 commented 5 months ago

Yes, that could explain it, i haven't yet tested item piles in v12, was waiting for an official update

Saibot393 commented 3 months ago

From my testing everything should now work correctly with the newest versions of Lock & Key and Item Piles