Saibot393 / Rideable

A Foundry VTT module which allows Tokens to be ridden
MIT License
7 stars 3 forks source link

Mount on Enter does not seem to work. #30

Closed devteamplus closed 10 months ago

devteamplus commented 10 months ago

I turned on the "Mount on Enter" availability in the global settings. I then set a token to allow "Mount on Enter". However, moving tokens within the space of that rideable token do not mount the token.

Foundry v11.308 Rideable v2.7.1 OS: Linux AWS using NodeJS v16

devteamplus commented 10 months ago

Here's a video link to see what I'm seeing:

https://app.screencast.com/Do8lMZ08raSkl

Saibot393 commented 10 months ago

I think i found the bug, should be fixed with v2.7.2. Also, that is probably the most beautiful scene (Battlemap and Tokens) i have ever seen in any VTT.

devteamplus commented 10 months ago

Thanks.. it’s a base Baileywiki Town Center map, with my own customizations. 😊

@.*** Lee Fuller Chief Technology Officer

Phone/Text: 951-216-3560 Email: @.**@.>

From: Saibot393 @.> Sent: Monday, August 28, 2023 8:16 AM To: Saibot393/Rideable @.> Cc: Lee Fuller @.>; Author @.> Subject: Re: [Saibot393/Rideable] Mount on Enter does not seem to work. (Issue #30)

I think i found the bug, should be fixed with v2.7.2. Also, that is probably the most beautiful scene (Battlemap and Tokens) i have ever seen in any VTT.

— Reply to this email directly, view it on GitHubhttps://github.com/Saibot393/Rideable/issues/30#issuecomment-1695881016, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A54SEGB5P42V7QXZNCEQSR3XXSY2TANCNFSM6AAAAAA4BRXQMI. You are receiving this because you authored the thread.Message ID: @.**@.>>

devteamplus commented 10 months ago

Just a side note here... I have successfully mounted a token using "on enter". And if there are other tokens on it, like the party wagon you see in the video... the other mounted tokens rearrange positions as they should. However, when one of those tokens dismounts, the arrangement is still the same, until the ridden token moves. Would it be logical to rearrange the tokens still mounted back to proper positioning, once one of the tokens dismounts?

I can see that it may be problematic if they arrange themselves so that one of the still-mounted tokens arranges itself on top of the dismounted token. So, this is why I'm asking.

Thanks for the super quick responses!

Saibot393 commented 10 months ago

The problem would be exactly as you described, the tokens left mounted would rearrange and the unmounted token would probably be hard or impossible to select. I could implement something that checks if a token has left the mounted token and only then rearranges the tokens but that would be quite resource intensive for very little gain. I will therefore probably leave it as is for now, considering that it is (in my opinion) a small annoyance at worst.

devteamplus commented 10 months ago

Agreed. Makes total sense. That's pretty much how I was thinking about it. I didn't realize it would be so resource-intensive to check for a "leaving" token, but that's the reality - so best to leave it as is.

Thanks!