search

Saibot393 / Rideable

A Foundry VTT module which allows Tokens to be ridden
MIT License
7 stars 3 forks source link

"Follow" grapple variant doesn't function #75

Closed TrofimSelbs closed 2 months ago

TrofimSelbs commented 2 months ago

Hey! Love the module. I have been having issues with "Follow" variant of grappling. It applies grappled DF CE, but it doens't follow the grappler. Other methods, such as "inside" & "below" work. I am on v11 of foundry vtt 315, dnd 5e 3.1.1. Could you please look into this? Thank you!

ps: sorry for the quality. GitHub wouldn't allow to upload a bigger file

https://github.com/Saibot393/Rideable/assets/124184162/446a4152-92bb-440b-ac9e-a46b1b10ca51

Saibot393 commented 2 months ago

There is a bug with following i did not yet have time to track down. That bug (as far as i know) only happens when using the "Simple path history" following algorithm. If you are using the "Simple path history" algorithm, i think switching to "routinglib" (after installing routinglib) might fix the bug. Are you using "Simple path history"? Also, glad you enjoy the module

TrofimSelbs commented 2 months ago

Is it a module? If yes - then no, I don't use it. I have routinglib though. Additionally, I was able to reproduce this issue with just these modules active

image

Saibot393 commented 2 months ago

If you have routinglib enabled in the world there should be a world setting called "Following algorithm" in the rideable settings where you can switch to routinglib. The routinglib algorithm is the recommended following algorithm, the simple path history one is mainly intended as a low resource option and in case routinglib isn't availbale after a foundry version update.

TrofimSelbs commented 2 months ago

Thank you! Yes, this works. I think I chose it cos it said "resource light" and then forgot. Much appreciated!

Saibot393 commented 2 months ago

I will try to fix the path history as soon as possible

Saibot393 commented 2 months ago

I finally got around to fixing the simple path history algorithm for grapple following. Should now be working correctly with v2.21.7

TrofimSelbs commented 2 months ago

wow, awesome! will try it out. thank you! it has the same functionality now as routinglib?

Saibot393 commented 2 months ago

Basically yes. In general i would still recommend routinglib if possible since it will normally find the more effective or smater ways, path finding will require less processing though

TrofimSelbs commented 2 months ago

got it. I think I will stick to path, as my players have potatoes for PCs. But if any issues - will change. Thank you for your time, I really appreciate it