Saibot393 / Rideable

A Foundry VTT module which allows Tokens to be ridden
MIT License
8 stars 3 forks source link

Tokens pass through walls while mounted #76

Closed zeleni3 closed 4 months ago

zeleni3 commented 4 months ago

Tokens pass through walls when mounted on a token with piloting option enabled.

Only Ridable and routinglib are enabled FoundryVTT version 12 System DnD 5th Edition

rideable-wall-bug

Saibot393 commented 4 months ago

I will look into a fix for that

Saibot393 commented 4 months ago

I have added a collision check with v3.0.1

zeleni3 commented 4 months ago

It is still possible to enter a wall from the side if it is lined up with the center of the token.

rideable-wall

Saibot393 commented 4 months ago

That should now be fixed with v3.0.2

zeleni3 commented 4 months ago

You can still enter a wall but now you get stuck inside and can only exit from one of the end points.

Saibot393 commented 4 months ago

Entering the wall is also possible in core foundry, i don't think there is much more i can do about that. I will try to see what i can do about getting stuck though

zeleni3 commented 4 months ago

In core foundry it is possible to enter a wall in a similar way but the token is still on one side and is unable to see or pass through to the other side. Honestly, how it was in v3.0.1 was pretty good already in my opinion. It was a minor issue and also easy to work around. And if it still happens, it will usually only be in a situation where the riding player already had access to both sides of the wall anyways.

Saibot393 commented 4 months ago

I tried another version with v3.0.3. It should now be almost impossible to enter a wall with piloting. I have also added a per tile/token setting to enable/disable the collision (default off for tokens), since i realised, that the collision check might cause problems for token attacher tokens with attached walls

zeleni3 commented 4 months ago

It seems to work perfectly now :) Thank you for your hard work!

Saibot393 commented 4 months ago

Glad to hear that