Saibot393 / Rideable

A Foundry VTT module which allows Tokens to be ridden
MIT License
7 stars 3 forks source link

Familiars jump around and do not get smaller #85

Open dodds-steven opened 2 weeks ago

dodds-steven commented 2 weeks ago

I was playing with this mod the other night. LOVE THE IDEA! we enabled Familiars so the mages can have their cats ride on their shoulder. when they walk around it seems like the familiar often gets lost in the walls and bounces around or detaches. have you seen this before? I also have the size change when riding enabled and set to .6, and it doesn't seem to work with familiars? have not played with trying to make a horse or wagon yet.

we are using the ARS game system and V12. I do have several other plugins running but nothing that effects tokens that I'm aware of. later this week I hope to try things in a test environment to help narrow down possible issues there...

Saibot393 commented 2 weeks ago

I can currently not replicate the behaviour you described for familiars. Trying it in a test environment as you mentioned would be quite helpful, i would suggest trying to see if it also happens in a new empty world and using Find the Culprit. Besides that, could you send me screenshots of your Rideable world settings and of the ridden tokens Rideable settings?

dodds-steven commented 2 weeks ago

today I ran some more tests and the riding familiar didn't jump all over the place... there was a game system update, but I don't know how that would effect it. it only fixed a bug with rolling initiative. tested in and out of combat. the familiars not scaling is still an issue however. I also tested both as a familiar and a mountable token. my setting is .5 for adjusted scale factor. Could this issue may be related to me using the new v12 Dynamic Token ring?

FAMILIAR RIDING FAMILIAR NOT RIDING
dodds-steven commented 2 weeks ago

oh, I haven't touched the on token riders scale, its still set to 1 and the Offset doesn't seem to effect familiars when they are riding?

dodds-steven commented 2 weeks ago

here are the settings screen shots

Screenshot 2024-09-05 at 4 50 36 PM Screenshot 2024-09-05 at 4 50 51 PM Screenshot 2024-09-05 at 4 49 36 PM
Saibot393 commented 1 week ago

Ahh, sorry i wanted to mention the part with the familiar scaling in my last answer, i just forgot. The problem with the scaling is, that foundry only allows for certain token sizes. I assume you familiar has a size of 0.5x0.5? This is as far as i know the smallest possible size for tokens. I plan on adding a purely visual scaling option in a later update though. That the offset does not affect familiars is intentional.

dodds-steven commented 1 week ago

Ohhh I see.
With v12 dynamic tokens, it could be handy to let us move them in a bit more? as you can see in my screen shot, they are not even overlapping the edge of the ring. one reason I was hoping to make them smaller than they are, was to not hang out of the square as much.

Screenshot 2024-09-06 at 5 15 42 PM

love the mod, and look forward to your future development.

Saibot393 commented 1 week ago

I will look into adding a setting to enable the offset for familiar riders with the next update. Glad to hear that you enjoy the module.