Saibot393 / enhancedcombathud-pf2e

GNU General Public License v3.0
2 stars 3 forks source link

Kineticist Elemental Blast Support #11

Closed Legilas closed 5 months ago

Legilas commented 5 months ago

Hi there!

I've been testing your module and love the pf2e support so far. My pal plays a Kineticist and had some issues with the usage of Elemental Blasts. We can drag and drop the Elemental Blasts into the weapon set as described in the changelogs of version 1.1.0, the problem is that the Blasts then do not have options for an attack roll, MAPs and the such. Only the info card about the general action is printed to the chat. Also, no toggles for a melee or ranged blast are available or switches for damage types, which can be used given the right feats.

Am I missing something, or is this indeed a feature that is not yet implemented or cannot be implemented due to its complexity? elemental_blast

Saibot393 commented 5 months ago

It seems like you draged the kineticist feat into the weapon set, if you instead drag the action into it, it should work correctly and look something like this: image

Legilas commented 5 months ago

Alright, interesting, I thought to have done it correctly. Maybe another screenshot: I dragged and dropped these two, which Action are you referring to? image

Saibot393 commented 5 months ago

Those should work, are there any errors in the console (F12)?

Legilas commented 5 months ago

Indeed there is an error, but it only seems to be a notification of a deprecated function:

image

Legilas commented 5 months ago

Hm, tracking back in the log, there is also the following uncaught exception when opening the HUD through the left sidebar:

image

Legilas commented 5 months ago

I also tested the air elemental blast that you gave as a visual example and it still does not seem to work, so its not tied to the different type of blast :/

Saibot393 commented 5 months ago

Which version of the module are you running?

Legilas commented 5 months ago

Very interesting, its the 1.0.1 version, your hunch is correct. As I just now installed the module I simply assumed it would be the most recent version. Looks as though I was mistaken in that assumption. I'll install the new version right now. Gosh, not coming up with this myself is quite embarassing. Thanks for your time regardless. ^^

Saibot393 commented 5 months ago

no problem, out of interest, are you using forge?

Legilas commented 5 months ago

No, I'm self hosting my server on a raspberry pi.

Saibot393 commented 5 months ago

Hmm, interesting, forge would have explaned it

Legilas commented 5 months ago

Ok, now it gets weird. I updated the version, now version 1.1.2, and I still have the same issue. Even created a new character to make absolutely sure its not tied to old data. Maybe I'm still missing a step or two, so I'll list all the steps I took:

  1. Selected the Kineticist

  2. Opened the HUD

  3. Use Channel Elements to activate the aura and create the specific blast attacks in the sheet

  4. Drag and drop the created Blast Actions into the weapon set image

  5. I get this generic elemental blast as in the screenshot without attack rolls and all. Now with an icon for whatever reason though.

Saibot393 commented 5 months ago

Do you have any modules installed that could interfere with kineticist actions?

Legilas commented 5 months ago

Just now, I simply deactivated all modules except the HUD, no change sadly. I recently updated the PF2e system to its newest version (5.13.4) and the Foundry version is version 11.315.

Saibot393 commented 5 months ago

Could you enter this into the console, then drag the blast onto the weapon set and send me the output (it might not work the first time): ui.ARGON.components.weaponSets._onDrop = (event) => {console.log(JSON.parse(event.dataTransfer.getData("text/plain")))} The ouputs should (after unfolding it) look a little like this: image

Legilas commented 5 months ago

Gladly, the output is the following: image

Saibot393 commented 5 months ago

could you send me your world file (without the media data)?

Legilas commented 5 months ago

Could you specify which specific file that is? I'm currently in the data folder of my world and there is a substantial amount of files. Are we talking of simply the entire folder minus assets or a specific file?

Saibot393 commented 5 months ago

yes, the entire folder without the assets

Legilas commented 5 months ago

Bugworld.zip Alright, hope thats all you require.

Saibot393 commented 5 months ago

Looks right on first glance, thank you. I will take a look at it tomorrow

Saibot393 commented 5 months ago

Now its getting truly strange, when i use "Yor" to drag the blasts into the weapon sets, the blast is set up correctly: image The attacks already present however does not work. Which browser are you using? I have released special debug version that can be manually installed via this link: https://github.com/Saibot393/enhancedcombathud-pf2e/releases/download/debug1/module.json It will output some info into the console when an item is dragged into the weapon set, could you drag the blast into it again and send me the output, it should look something like this (possible longer): image

Legilas commented 5 months ago

Now, I'll be... It works. I sleep over it, and it works. How? xD

I díd not restart the server, I didn't even restart the world, the server should in theory be in the very same state I left it yesterday. And yet... wtf. Ok, whatever, I'll not let myself be gaslighted by Foundry, Issue closed, this time for good. Thank you for your patience. :) image

... But seriously, how.

Saibot393 commented 5 months ago

Foundry taketh, foundry giveth, at least its solved now

Legilas commented 5 months ago

Amen.