Perceptive stealth is not set when stealth check is rolled

Saibot393 / perceptive

A small Foundry VTT module to handle a few vision based enhancements

MIT License

9 stars 5 forks source link

Perceptive stealth is not set when stealth check is rolled #102

Closed TheXeno30 closed 1 week ago

TheXeno30 commented 3 months ago

Perceptive stealth is not set when stealth check is rolled - Can be spotted does.

Where am i going wrong with the settings :)

Saibot393 commented 3 months ago

Assuming you have both the settings "Automate token can bespotted" and "Use perceptive stealthing" perceptive stealthing should be set automatically when rolling stealth. If that is not the case:

Are there any errors in the console(F12)?
Are any other modules activated and does the effect work as expected when those modules are turned of?
What is the setting "Make spotted tokens visible" set to and is there any token in the test scene that could possible spot the test token?

TheXeno30 commented 3 months ago

Both "Automate token can bespotted" and "Use perceptive stealthing" ia on
think it might be the Dfreds CE new effects
"Make spotted tokens visible" is set to never

Saibot393 commented 3 months ago

yes that seems like it could be the cause, i will look into a fix

TheXeno30 commented 3 months ago

thanks for a very cool module btw - my rogue loves it. :)

Saibot393 commented 3 months ago

happy to hear that

Saibot393 commented 3 months ago

The bug should now be fixed with v4.0.7, i will leave the issue open for now, in case i missed something

TheXeno30 commented 3 months ago

that was quick - thanks.

TheXeno30 commented 3 months ago

it works :) But... don't know if it your module or vision 5e that controls the hearing. When your are spotted by a token and you are in darkness the token should not be spotted with vision but with hearing. (The bandit has spottet the rogue)

Saibot393 commented 3 months ago

Ah, yes, that is one of the things that is currently not possible/compatible with perceptive. I will look into adding that when i have a time, possible in combination with Vision 5e.

TheXeno30 commented 3 months ago

Isn't Perceptive suppose to add a inaudible and invisible CE to the token? It still hides the token correctly, but no CE

Saibot393 commented 3 months ago

If the following settings are activate those effects should be added: "DFreds Convenient Effects Integration" "Vision 5e Integration" "Apply system stealth effect"

TheXeno30 commented 3 months ago

all on but no CE effect or system effects

Saibot393 commented 3 months ago

Which versions of Foundry, D&D and DFreds CE are you using?

TheXeno30 commented 3 months ago

V12.331, DnD 3.3.1, Dfreds 7.0.1

Saibot393 commented 3 months ago

I completely missed that DFreds has a v12 compatible version now, something probably changed in the api, i will look into it.

TheXeno30 commented 3 months ago

Came out yesterday 😂😂 so I think it’s ok not to know. Thank you for looking into it.

Saibot393 commented 3 months ago

I have restored DFreds CE compatibility with v4.0.8. However, it seems like Vision 5e does no longer add the "Inaudible" effect to the DCE effects. Since i do not use Vision 5e myself i am not sure how the hearing system works now (could be, that it also is not updated to the newest DCE version).

TheXeno30 commented 3 months ago

thank you so much. Vision 5e (the most incorrect title ever :)) is working correctly, except as described above, but it doesn't add the inaudible effect anymore.

Saibot393 commented 3 months ago

For the time being: I am not entirely sure if Vision 5e still interacts with effects that are simply called "Inaudible", if that is the case, adding an effect named "Inaudible" to the DCE effect folder will still cause Perceptive to add it (assuming the appropiate settings are activated)

TheXeno30 commented 3 months ago

it works :)