search

Saibot393 / perceptive

A small Foundry VTT module to handle a few vision based enhancements
MIT License
9 stars 5 forks source link

Console message and no peeking #48

Open MapperD opened 10 months ago

MapperD commented 10 months ago

I keep getting this error in the console, though it doesn't seem to cause any issues that I can see? Image2 It is generated during startup and every time I touch/move a token.

Additionally the peek feature functions, however, any tokens that would be in view are not visible. Image3

No idea if these may be related. I turned off all other Modules and the message is the same so no conflict that I could tell. I don't use the the Spot Invisible setting since Harnmaster detection rules don't work the same as PF or D&D so I don't think that could be an issue?

Saibot393 commented 10 months ago

The error above is a small error i already found that should not cause any problems and is not related to the peeking bug, i will fix the error with a small patch shortly. Regarding the peeking behaviour, does that also happen with all other modules turned off? Are you using the elevated vision or the levels module?

MapperD commented 10 months ago

That's good to know. As for the peeking error, after trying it again it does appear to be a module but I will need to play around more to figure out which one since Find the culprit though helpful when I run it on the second pass it always crashes the system so it is disabling something I need to continue. I'll fiddle with it and let you know if I find it.

Saibot393 commented 10 months ago

Thank you

MapperD commented 10 months ago

Ok it didn't take as long I thought, as it was near the top of the list. It seem not to play well with Alternative Token Visibility. Not big issue for me as it doesn't work well with the Harnmaster system but still a cool little feature.

Saibot393 commented 10 months ago

Thanks for letting me know, i will see what i can do about that.

Saibot393 commented 10 months ago

The bug with the console message should be fixed with v3.0.1

Saibot393 commented 10 months ago

To make sure, that this is not more than one bug. The only way i could get this behaviour with peeking to appear was with Alternative Token Visibilitys Line of Sight Algorithm set to "Token area 3D", is that the same setting you are using?

Saibot393 commented 10 months ago

The new v3.0.3 should solve the issue with the peeking for the "Token area 3d" algorithm. I have noticed, that the "Corners (dnd5e DMG)" algorithm has the same issue, though the way this algorithm seems to calculate visibility seems quite far removed from the default Foundry algorithm it is therefore inherently incompatible with Perceptive, as far as i can tell.

MapperD commented 10 months ago

Just played with it and yeah the Corners (dnd5e DMG) actually freezes my canvas so I can't interact with any tokens. I was using Points on Token not Token Area 3d but both have the same results. Setting it to Token Area seems to work fine (so far) so I'll keep it there for now. As for the error message it is gone, thanks.

Saibot393 commented 10 months ago

I think the freezing with dnd5e DMG always happens on gridless maps (independent of other installed modules). Both the points on tocken and Area 3d seem to be working for me with the newest fix.