Saibot393 / perceptive

A small Foundry VTT module to handle a few vision based enhancements
MIT License
8 stars 3 forks source link

[Bug] Phantom Walls being created #56

Closed badgkat closed 6 months ago

badgkat commented 8 months ago

This has happened several times, and I believe I have narrowed it down to perspective. It may be associated with the walls created during lock peeking.

My players will open a door and they have no vision through it.

Screenshot 2023-12-13 212324

I look in the walls tab, and nothing is amiss

Screenshot 2023-12-13 212232

I disable perceptive, and I can now see there are a number (sometimes dozens) of walls in that doorway.

Screenshot 2023-12-13 212118
Saibot393 commented 8 months ago

I will look into it. Are these doors set as peekable or moving?

Saibot393 commented 8 months ago

Also, what other modules are you using?

Saibot393 commented 8 months ago

I did a bit of testing but can not replicate the creation of these walls. I have a rough idea what could cause that. It likely is some kind of compatibility problem with another module.

badgkat commented 8 months ago

Also, what other modules are you using?

Too many to count. Though most are content modules and shouldn't affect the canvas, key possibilities for conflicts:

PF2e Perception Monk's Improved Walls Wall Hight Levels

Full list (not all of these were enabled the first time it happened):

Active Modules

Advanced Drawing Tools v2.1.0 Bugs URL Arms Reach v2.3.6 Bugs URL Auto-Rotate vv1.3.17 Bugs URL Baileywiki Nuts and Bolts v0.2.5 Battlezoo Ancestries: Dragons for Pathfinder 2e by Roll for Combat v1.4.2 Battlezoo Ancestries: Dungeons for Pathfinder 2e by Roll for Combat v1.2 Battlezoo Ancestries: Year of Monsters for Pathfinder 2e by Roll for Combat v12.01 Battlezoo Bestiary for Pathfinder 2e by Roll For Combat v2.5 Battlezoo Bestiary: Strange and Unusual for Pathfinder 2e by Roll For Combat v1.0.1 Battlezoo Jewel of the Indigo Isles for Pathfinder 2e by Roll for Combat v3.1.1 Battlezoo — World of Battlezoo: Indigo Isles for Pathfinder 2e v1.1.2 Better Roofs v1.9.2 Break Time v11.03 Bugs URL Carousel Combat Tracker v2.6.1 DF Settings Clarity v3.3.0 Bugs URL Dice So Nice! v4.6.8 Bugs URL Dice Stats v1.15.0 Dice Tray v2.1.5 Drag Ruler v1.13.8 Bugs URL PF2e Drag Ruler Integration v3.0.5 Footsteps of Otari v2.0.1 Force Client Controls v1.0.5 Bugs URL Forien's Quest Log v0.7.12 Bugs URL FXMaster v4.0.2 Bugs URL Jack Kerouac's Animated Spell Effects: Cartoon v0.4.5 JB2A - Jules and Ben's Animated Assets - Free Content v0.6.3 PF2E Troubles in Otari Enhanced Beach Camp by Wise v1.2.3 JB2A - Patreon Complete Collection v0.6.2 Kris's Compendium of Trade Goods - PF2e edition v1.1.3 Chat Commander v2.0.1 Bugs URL lib - Color Settings v3.0.1 Library: Scene Packer v2.7.8 Bugs URL libWrapper v1.12.13.0 Bugs URL Settings Extender v1.2.2 socketlib v1.0.13 Bugs URL Lock & Key v2.3.0 Bugs URL Baileywiki Maps Premium v0.5.5 Baileywiki Maps Towns v0.5.8 Mass Edit v1.51.0 Michael Ghelfi Studios Audio Pack v1.4 Module Management+ v2.2.3 Bugs URL Monk's Active Tile Triggers v11.17 Bugs URL Monk's Bloodsplats v11.11 Bugs URL Monk's Combat Details v11.09 Bugs URL Monk's Combat Marker v11.03 Bugs URL Monk's Enhanced Journal v11.07 Bugs URL Monk's Hotbar Expansion v10.1 Bugs URL Monk's Little Details v11.05 Bugs URL Monk's PF2e Encounter Aftermath v11.05 Bugs URL Monk's Player Settings v11.04 Bugs URL Monk's Scene Navigation v11.02 Bugs URL Monk's Sound Enhancements v11.05 Bugs URL Monk's TokenBar v11.08 Bugs URL Monk's Wall Enhancement v11.02 Bugs URL Moulinette Core v11.6.4 Moulinette Game Icons (module) v11.1.1 Moulinette Scenes (module) v11.1.3 Moulinette Sounds & SoundPad (module) v11.8.2 Moulinette Tiles (module) v11.1.0 Moulinette Image Search (module) v11.0.1 Multiface Tiles v1.0.11 Party Resources v1.6.0 Pathfinder 2e: Abomination Vaults v3.1.0 Pathfinder Beginner Box v3.0.0 Pathfinder: Harrow v1.1.1 Pathfinder: Kingmaker v2.0.0 Pathfinder Token Pack: Bestiaries v1.0.6 Patrol v1.3.4 Perceptive v3.1.7 PF2e Action Support Engine v0.0.96 PF2e Action Support Engine Handlers v0.0.33 PF2e Action Support Engine Macros v0.0.25 PF2e Action Support Engine Measure Helper v0.0.18 PF2e a shopping experience v3.0.0 PF2e Companion Compendia v6.0 PF2e Convenient Consumables v1.0.1 Bugs URL PF2e Dailies v2.16.0 Bugs URL PF2e Dorako UX v1.2.0 Bugs URL PF2e Dying v0.0.12 PF2E Exploration Effects v3.0.0 pf2E Extempore Effects v1.8.2 Bugs URL PF2E Fatigue v1.3.7 PF2e Flip Token v0.0.3 Bugs URL PF2e Hands Management (Reminder) v0.0.14 Bugs URL PF2e Interactive Token Tooltip v1.57.0 Bugs URL PF2e Keybind Menagerie v5.3.2 PF2e Mercenary Marketplace Volume 1 v3.0.5 Pf2E Modifiers Matter v1.8.8 Bugs URL PF2E Monster Maker v1.2.3 PF2e Party Sheet Helper v0.0.49 Bugs URL PF2e Perception v0.33.0 Bugs URL PF2e Ranged Combat v4.0.8 Bugs URL PF2e Reaction Checker v0.2.53 Bugs URL PF2e Relics v0.9.8 pF2e See Simple Scale Statistics v1.4.1 Bugs URL PF2e Toolbelt v1.26.0 Bugs URL PF2e Troops Helper v0.0.5 PF2e Tweaks by Ustin v0.7.2 PF2e Use all module tokens v1.4 PF2e Weapon Trait Options v0.0.5 PF2e Workbench v5.37.12 Bugs URL Pin Cushion v1.9.11 Bugs URL Polyglot v2.3.18 PopOut! v2.14 Bugs URL Quick Insert - Search Widget v2.8.3 Bugs URL Rideable v2.17.0 Bugs URL routinglib v1.1.0 Bugs URL Select tool everywhere v1.4.1 Sequencer v3.1.4 Bugs URL Automated Animations v4.2.69 PF2e Animation Macros v2.17.2 PF2e Summons Helper v0.0.5 Simple Calendar v2.4.3 Bugs URL Smart Target v1.0.1 Bugs URL Splatter v3.4.2 Sync Token Names v1.0.5 Tactical Grid v1.18.6 Tagger v1.4.5 Bugs URL TheRipper93's Module Hub v2.0 Tile Scroll v2.2 Token Attacher vv4.5.15 Baileywiki Cabal Dungeon v0.2.3 Baileywiki Modular City - District 01 v0.2.4 Baileywiki Modular City - District 02: Docks v0.2.0 Baileywiki Modular City - District 03: Temples v0.2.0 Baileywiki Modular City - District 04: Ruins and Slums v0.2.1 Baileywiki Modular City - District 05: Affluent v0.2.1 Token Lean: Peek Around Corners v2.1.0 Bugs URL Token Magic FX v0.6.5.0 PF2e TokenMagic Integration v0.2.0 Token Magic FX - Automatic Wounds v1.1.6 Bugs URL Token Mold v2.20.3 Bugs URL Minimal UI v1.6.8 PF2e Dorako UI v3.3.2 Bugs URL Vauxs' Chat Enhancements v0.4.0 Bugs URL Wall Height v5.1.3 Levels v4.2.9 Warp Gate v1.19.2 Foundry Summons v1.7.0 Bugs URL

badgkat commented 8 months ago

I will look into it. Are these doors set as peekable or moving?

Peekable

Saibot393 commented 8 months ago

I have released v3.1.8, i am not sure if completely resolves the issue, but it should make the bug atleast less likely to appear

Dyrnwyrm commented 8 months ago

Got the same issue when i resized a map from 150 grid to 100, also for some reason when i pick an option from opening doors like sliding or swinging my players got this weird issue of the door opening and closing

Saibot393 commented 8 months ago

Are you using Monk's Wall Enhancement for resizing? Also, did this happen with the newest perceptive version?

Dyrnwyrm commented 8 months ago

Yep Monk´s Wall enhancement, the issue is that even when i deleted all the walls the phantom walls persist, i ended up deleting all the scenes and making the walls manually and my other issue seems like is related to choosing swinging doors or the other option (not foundry default) maybe you want the module list?

Saibot393 commented 8 months ago

I tested a bit and can' replicate the behaviour. I will continue investigating after christmas. Just in case it is some kind of strange compatibility issue, which modules are you using?

Dyrnwyrm commented 8 months ago

sure let me add the list and the door issue is for players only for some weird reason i 100% sure is something related to using other type of doors that are not "core behavior"

Active Modules

Action Pack v11.2 Bugs URL Active Auras v0.9.2 Bugs URL Active Token Effects v0.7.0 Bugs URL Advanced Macros v2.0.5 Bugs URL Anonymous v1.4.4 Bugs URL Arms Reach v2.3.6 Bugs URL Build-a-Bonus v11.6.2 Carousel Combat Tracker v2.6.1 Chat Portrait v0.9.4 Bugs URL Cleaner sheet title bar v1.5.1 Combat Booster: Turn Marker, Recent Actions and more v3.6.2 DDB-Importer: A D&D Beyond Integrator v3.6.0 DFreds Convenient Effects v6.0.0 Bugs URL DFreds Droppables v3.0.1 Bugs URL DFreds Effects Panel v3.1.0 Bugs URL Dice So Nice! v4.6.9 Bugs URL DND5E Scriplets - 5E QOL bits and pieces v0.23 Dynamic effects using Active Effects (DAE) v11.1.7 Bugs URL Midi QOL v11.3.10 Bugs URL Chris's Premades v0.9.14 Midi SRD v11.0.0 Bugs URL Effect Macro v11.0.3 Foundry Redirect: Better invitation links v2.0.4 Grid Scaler v1.4.4 Health Estimate v31.7.9 Bugs URL Illandril's Inventory Sorter (5e) v2.3.0 Bugs URL Item Collection\Item Container for Dnd5e v11.0.4 Item Piles v2.8.12 Bugs URL JB2A - Patreon Complete Collection v0.6.3 Kris's Compendium of Trade Goods v0.13 lib - Color Settings v3.0.1 🏷️ Item Tags (Library) v1.1.0 Bugs URL libWrapper v1.12.13.0 Bugs URL socketlib v1.0.13 Bugs URL Limits v1.1.0 Bugs URL Magic Items 2 v1.3.3 Bugs URL Universal Battlemap Importer v3.0.0 Mass Edit v1.54.0 Material Components v11.1.3 Bugs URL Module Management+ v2.2.3 Bugs URL Monk's Bloodsplats v11.11 Bugs URL Monk's Combat Details v11.09 Bugs URL Monk's Combat Marker v11.03 Bugs URL Monk's Enhanced Journal v11.08 Bugs URL Monk's Player Settings v11.04 Bugs URL Monk's TokenBar v11.09 Bugs URL Monk's Wall Enhancement v11.02 Bugs URL Perceptive v3.1.8 Polyglot v2.3.18 Rarity Colors v0.3.7 Bugs URL Rest Recovery for 5E v1.5.2 Reverse Initiative Order v1.2.1 Bugs URL Revised Weapons & Equipment v11.0.0 Rideable v2.17.2 Bugs URL routinglib v1.1.0 Bugs URL Sequencer v3.1.4 Bugs URL Automated Animations v4.2.69 D&D5e Animations v1.6.0 ✨ Automated Objects, Interactions and Effects 🔥 v1.1.5 Bugs URL Universal Animations v0.1.3 Show Token Art v1.0.3 Shuggaloaf's Simple NPC Generator vv4.0.11 Simple Calendar v2.4.3 Bugs URL Simple Weather v1.8.0 Bugs URL SmallTime v1.19.1 Bugs URL Smart Target v1.0.1 Bugs URL Stairways (Teleporter) v0.10.2 Bugs URL Stealthy v3.13.2 Bugs URL Tagger v1.4.5 Bugs URL Template Macro v11.0.1 Tidy5e Sheet v0.10.0 Bugs URL Times Up v11.1.1 Bugs URL Token Attacher vv4.5.15 Token Auras v2.7 Token Ease v1.2.1 Token Magic FX v0.6.5.0 Token Magic FX - Automatic Wounds v1.1.7 Bugs URL Token Mold v2.20.3 Bugs URL Token Variant Art v4.62.5 Bugs URL Token Warp v11.0.1.1 Bugs URL Variant Encumbrance+Midi vv0.13.5 Bugs URL Vision 5e v1.12.0 Bugs URL Walled Templates v0.6.10 Warp Gate v1.19.2 Arbron’s Summoning v1.1.4 Bugs URL

Saibot393 commented 8 months ago

You mentioned that this bug only appears for players, which makes it sound like it might be lag related. I have released a small fix with v3.1.9 that might fix the bug, should it indeed be lag related.

pavelradvan commented 8 months ago

Hi. I have same problem. It is appearing for GM and for Players also. When I disable "Can be lock peeked" it is OK. There is also another bug - but it appears to be same - when I set some secret doors "Can be spotted" and I am using Levels module that secret doors are visible on all levels in same position. After I disable "Can be spotted" all is OK. In console is this error: jquery.min.js:2 The specified value "-Infinity" cannot be parsed, or is out of range. More details: image

Saibot393 commented 7 months ago

I have released v3.1.10 which should prevent this from happening by preloading all walls necessary

pavelradvan commented 7 months ago

Hi. I tested it after update and problem is still there - same problematic walls and doors with Levels module enabled with "spotted" on or with "peekable". I even tested all in empty world with only needed modules and it is doing same...

Saibot393 commented 7 months ago

So the "phantom" wall are still appearing? Are you self hosting or you using a service like forge? The one with the secret doors being visible will need a bit more a time and the console warnings with Infinity can be ignored

pavelradvan commented 7 months ago

Yes, that phantom automatic walls are appearing. I have dedicated computer with Windows 11 Pro for Foundry. Foundry is latest v11 and running in Node not as Windows app. I am connecting to it by local LAN. I also tried to restart server several times and it is same. I also have VPS from my server hosting provider, but it is now disabled, because I am preparing all on local server and then just transfer "data" folder to VPS. That visible secret doors on another levels seems to be only for GM(me) not for players, but it is quite annoying to have all secret doors duplicated on all levels...

Saibot393 commented 7 months ago

Could you send me the world file of this empty world you had the phantom walls appear in?

pavelradvan commented 7 months ago

OK. I prepare walls and doors with active setting from your module. Which file exactly you would like to have? How I could send it with some privacy ?

Saibot393 commented 7 months ago

i need the world directory(without assets like images and sound files) from the foundry data>worlds directory, if you want you can send it to me via discord DM at saibot5279

pavelradvan commented 7 months ago

I sent all on Discord with DM to you

pavelradvan commented 7 months ago

I have od Discord name wyrm9426

Saibot393 commented 7 months ago

The issues described here should be solved, i will close this issue soon unless i hear otherwise