search

Sailias / cryptocoin_payable

Ruby Crypto Coin payment processing gem
MIT License
37 stars 16 forks source link

Remove mnemonic requirement for eth #8

Closed mhluska closed 6 years ago

mhluska commented 6 years ago

Addresses https://github.com/Sailias/cryptocoin_payable/issues/3

I found one way to generate Ethereum addresses without relying on the mnemonic / private key. I had to switch to using BIP32 derivation and use .node_for_path() without the full derivation path. I'm honestly not sure why the method for computing these is different from the Bitcoin case but the generated addresses seem to match https://iancoleman.io/bip39/

Sailias commented 6 years ago

@mhluska this looks much better

mhluska commented 6 years ago

@Sailias I wonder if we should be incrementing the version at this point. On one hand this change will affect all generated Ethereum keys/addresses going forward and should probably get a major version bump. On the other hand, we haven't published a gem yet and the code is still in flux.

Sailias commented 6 years ago

if you test and merge this pull request, I would change the version, and create a tag. We can decide to publish it after we deem it completely stable.