SailyTeam / Saily

Modern. Fast. Beautiful.
The Unlicense
789 stars 57 forks source link

Unsatisfactory/dangerous handling of dist repos #84

Closed beer-psi closed 2 years ago

beer-psi commented 2 years ago

Blindly redirecting every user to the iOS 14 dist repo (as shown here) is totally not the way to handle repos, as packages that are built differently on 13 and 14, so Saily users on iOS 13 may break their jailbreak. Redirecting everyone to the iphoneos-arm64/1700 dist is ignorant at best, dangerous at worst.

A sensible (though rudimentary) way to handle "strand apt sources" (dist repos) would be:

"\(repo_url)/dists/\(dist_name)/Release"

I'm sure there are better ways to join URLs, but I'm also sure Saily can handle dist repos better, as they are definitely used in jailbreaks (BigBoss, Elucubratus, Procursus, etc.), unlike what you have stated on Twitter:

@​foxfortmobile @KatriCameron Then tell me what should I do. I know apt generate the full url using dist components but it is not all required for a jailbreak repo. Since we only use single url as the key to repo, there is no need to do the full implementation. You’re welcome to get that done yourself.

Lakr233 commented 2 years ago

Fine, I’ll do this next release.

worf1337 commented 2 years ago

you really sound like you don't give a shit

Lakr233 commented 2 years ago

Fixed in 969535c, if there is still cases I missed, reopen this issue.