Refactoring and harmonising a bit the style across tabs.
Some pending tasks/rough thoughts below, feel free to add more:
[ ] factor out the css style of the dash table
[ ] reduce the size / complexity of the callback functions:
[ ] define smaller functions,
[ ] move them to utils.py, layout.py or custom_components.py modules...
[ ] is there something we can do regarding the long parameter list?
maybe we can use temporary storages to save variables and split callbacks into smaller ones? (similar to ROI approach?). E.g. dashboard/modify_rows_selection would ideally only have the output("video-data-table", "selected_rows").
[ ] some agreements on nomenclature
e.g., ROI always capitalised, use ROI_tags rather than roi_names for coherence with event_tags...
[ ] rename 'input_config' to 'project_config'
[ ] rename 'pose_estimation_model_str' to 'model_str'
[ ] consider increasing line length? (see #59)
[ ] move VIDEO_TYPES to project_config
[ ] ensure frame indexing is the same in ROI tab and in dataframe export
in dataframe export, frames are zero-indexed
in ROI when we save the frame in which an ROI was defined, or when we allow the user to select a frame: are these zero-indexed?
[ ] ensure metadata yaml files keep the original keys order when a value is appended
I think after adding ROIs, the keys are sorted alphabetically
[ ] use trigger name explicitly in callbacks?
see here for example
Refactoring and harmonising a bit the style across tabs.
Some pending tasks/rough thoughts below, feel free to add more:
dashboard/modify_rows_selection
would ideally only have the output("video-data-table", "selected_rows").