SainsburyWellcomeCentre / aeon_experiments

Experiment workflows for Project Aeon
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Only copy data into CEPH from clean branches #186

Closed glopesdev closed 1 year ago

glopesdev commented 1 year ago

During the fast paced development cycle of the presocial workflows, we have been neglecting to do as many PRs to main as we would otherwise recommend. This will make it much harder to document in detail the changes we have addressed along the way once we finally merge everything back to the default branch.

The goal of this proposal is to promote fast iteration cycles on documentation, and motivate the use of both PRs and code review to further improve communication across arena developments.

The proposal is to allow experiments to copy collected data into CEPH for ingestion only when running off the repository main branch with no local modifications. Epochs collected using clean development branches would also be copied into CEPH but into a special devdata root folder which is not targeted for database ingestion. This will allow sharing debug test data for analysis within the team without contaminating stable datasets.

Finally, local tests should be allowed without disabling the export metadata script, which has been circumvented multiple times and ends up copying data into CEPH with no provenance information. Epochs collected using local uncommitted changes would be copied to a separate local folder which is not targeted by the robocopy script.

To achieve this the following steps would have to be resolved:

glopesdev commented 1 year ago

@jkbhagatio @Dario55 @lorycalca @aspaNeuro

glopesdev commented 1 year ago

Following meeting we decided on the following action points: