Closed sfmig closed 5 months ago
Attention: Patch coverage is 16.66667%
with 15 lines
in your changes missing coverage. Please review.
Project coverage is 37.17%. Comparing base (
c372e30
) to head (667c7ef
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
crabs/detection_tracking/detection_utils.py | 17.64% | 14 Missing :warning: |
crabs/detection_tracking/train_model.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
good call, dunno what happened there!
Instead of a default None
for ckpt_config
I used an empty dict cause it allows for a shorter syntax the first time we instantiate the MLFlowLogger
(and an empty dict is evaluated to false).
I also reduced things further and combined setup_mlflow_logger
with the suggested setup_logger
.
I'll request review again so that you can have a look before merging.
This PR comes from work in PR #136 and suggests a refactoring of the
setup_loggers
functions that keeps the structure oftrain_model.py
andevaluate_model.py
consistent.It defines: 1- a
setup_logger_with_checkpointing
function indetection_utils.py
that defines a logger with checkpointing. 2- asetup_logger_without_checkpointing
function indetection_utils.py
for a logger without checkpointing. 3- then we import these functions intrain_model.py
andevaluate_model.py
for their specificself.setup_logger()
methods. (And we can import that in the optuna code too in the future #188 )