search

Saishy / certainmangareader

[DISCONTINUED] Manga reading addon for firefox
GNU General Public License v2.0
9 stars 4 forks source link

Segfault on firefox 45.0.2 #10

Closed Keats closed 6 years ago

Keats commented 8 years ago

Trying to update the manga lists results in:

Vector smash protection is enabled.
[1]    29661 segmentation fault (core dumped)  firefox
[NPAPI 30007] ###!!! ABORT: Aborting on channel error.: file /build/firefox/src/firefox-45.0.2/ipc/glue/MessageChannel.cpp, line 1861

on Archlinux

Keats commented 8 years ago

@Saishy can you reproduce this?

Saishy commented 8 years ago

sorry for the delay, can you give me your manga list? you can export them if you update to beta.

Keats commented 8 years ago

Here's the export https://gist.github.com/Keats/cced29bf180b7631cdef2a8cecbe86f3

Keats commented 8 years ago

Updated to firefox 46 and the problem persists, let me know if i can help

Keats commented 8 years ago

@Saishy any update?

Saishy commented 8 years ago

Sorry, it's really hard to get a time for debugging, especially a side project :c

Keats commented 8 years ago

So i've emptied the list quite a bit, it seems the updater doesn't handle errors, ie if the manga is deleted on batoto, it will get stuck at that one. I guess the segfault was due to the same kind of issue

Saishy commented 8 years ago

I'm tackling the issue now, sorry for the delay.

Keats commented 8 years ago

Here's the cleaned down list https://gist.github.com/Keats/6829a009b6be682967213437213d564a

Saishy commented 8 years ago

A quick question, has you tried to log-in into bato.to before updating?

I think the culprit might be Ballroom e Youkoso, it's not possible to have access to the first chapter if you are not logged in. But I see no reason for it to give a segfault, and actually while updating your own list in my computer it doesn't give a segfault, only stops updating.

Keats commented 8 years ago

I just signed in and it managed to get further in the update but now segfaults again, the last it was able to update is Fairy Tail from that list

Saishy commented 8 years ago

Edit: Could you check if Dungeon Meshi is the problem?

Keats commented 8 years ago

Nope, removed it and it still crashes

Keats commented 8 years ago

Can you a debug option that gives a notification before updating a manga and space them by a few seconds? It would makes finding the culprit very fast, it's something after the letter B since those can update ok

Saishy commented 8 years ago

segfault_cmr.txt

I could get the error with this config, but it wasn't giving the error at all runs.

Keats commented 8 years ago

It seems to happen to random mangas actually. Do you have any idea why it happens?

Saishy commented 8 years ago

I have absolutely no idea, debugging it has been a pain since firefox doesn't have support for break on error.

Still working on it.

Keats commented 8 years ago

I might have a try at porting the extension to webextensions, those seem easier to maintain