Saishy / certainmangareader

[DISCONTINUED] Manga reading addon for firefox
GNU General Public License v2.0
9 stars 4 forks source link

Slowdown in firefox with shaky connection #19

Closed gagbo closed 6 years ago

gagbo commented 7 years ago

Hi,

I've been using the plugin just for a few weeks, but I just discovered today (the hard way) that when the connection is shaky (a bad educational wi-fi network where every other site won't load because of timeouts), the plugin really really slows Firefox down. The unresponsiveness makes the whole application near not usable.

Firefox behaved normally again when I deactivated the plugin so I think it comes from here. The main difference when I activated vs. when I deactivated the plugin was the messages I got when I close Firefox (launched in terminal) :

console.error: certainmanga: 
  Message: Error: Couldn't find the worker to receive this message. The script may not be initialized yet, or may already have been unloaded.
  Stack:
    processMessage@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/sync-worker.js:241:11
emitEventToContent@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/sync-worker.js:287:3
UpdateNextManga@resource://gre/modules/commonjs/toolkit/loader.js -> resource://certainmangareader-at-saishy/lib/main.js:801:3
notify@resource://gre/modules/commonjs/sdk/timers.js:40:9

I had ~50/100 copies of this block following each other when I closed Firefox (55.0.1 (64 bits)) and the module was on.

Saishy commented 7 years ago

Hi,

Woa, sorry for that experience :c The plugin is being reworked into webext, I will check that then.

On Mon, Aug 21, 2017 at 11:06 AM, Gagbo notifications@github.com wrote:

Hi,

I've been using the plugin just for a few weeks, but I just discovered today (the hard way) that when the connection is shaky (a bad educational wi-fi network where every other site won't load because of timeouts), the plugin really really slows Firefox down. The unresponsiveness makes the whole application near not usable.

Firefox behaved normally again when I deactivated the plugin so I think it comes from here. The main difference when I activated vs. when I deactivated the plugin was the messages I got when I close Firefox (launched in terminal) :

console.error: certainmanga: Message: Error: Couldn't find the worker to receive this message. The script may not be initialized yet, or may already have been unloaded. Stack: processMessage@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/sync-worker.js:241:11emitEventToContent@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/sync-worker.js:287:3UpdateNextManga@resource://gre/modules/commonjs/toolkit/loader.js -> resource://certainmangareader-at-saishy/lib/main.js:801:3notify@resource://gre/modules/commonjs/sdk/timers.js:40:9

I had ~50/100 copies of this block following each other when I closed Firefox (55.0.1 (64 bits)) and the module was on.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Saishy/certainmangareader/issues/19, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6zzMi3OFtCoE4pXI6aPFZrwhPC7XPyks5saY70gaJpZM4O9Y1M .

Saishy commented 6 years ago

Closed issue as plugin is currently being ported to webext.