search

SaitoTech / saito-lite-rust

a version of the Saito-Lite client written for compatibility with the Saito Rust client and binary data format
24 stars 28 forks source link

Mouseover adding scrollbar and messing with paragraphs on long posts. #2249

Closed arpee closed 9 months ago

arpee commented 11 months ago

This is distracting - would be good to (not remove and) have the scrollbar on long posts without mouseover, or have the scrollbar not cause the width to change.

Image

Image

f8daniel commented 11 months ago

The width doesn't change, but the scroll bar covers the text... can change to hidden scroll

Image

f8daniel commented 11 months ago

Alternate solution: add a padding-right to tweet-text.full (and tweet-text.preview) and have the scroll bar always be visible.

arpee commented 11 months ago

Screenshot_2023-12-22-00-18-37-47_e4424258c8b8649f6e67d283a50a2cbc.jpg

We now have scrollbars everywhere in mobile. Haven't checked desktop.

f8daniel commented 11 months ago

Not seeing scrollbars on prod or staging or local, firefox or chrome.

On Thu, Dec 21, 2023, 8:23 PM Richard Parris @.***> wrote:

Screenshot_2023-12-22-00-18-37-47_e4424258c8b8649f6e67d283a50a2cbc.jpg (view on web) https://github.com/SaitoTech/saito-lite-rust/assets/2867779/0a923c4e-2131-40e2-89ed-bf5c58c8207f

We now have scrollbars everywhere in mobile. Please fix.

— Reply to this email directly, view it on GitHub https://github.com/SaitoTech/saito-lite-rust/issues/2249#issuecomment-1866234513, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ3NQAAGIZ5K6O7J2AZZUQTYKQZ6XAVCNFSM6AAAAABA5VZUB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRWGIZTINJRGM . You are receiving this because you were assigned.Message ID: @.***>

f8daniel commented 11 months ago

Just change overflow-y: scroll to auto for .tweet-text.full in saito-tweet.css

On Thu, Dec 21, 2023, 8:43 PM Daniel Worlton @.***> wrote:

On Thu, Dec 21, 2023, 8:41 PM Daniel Worlton @.***> wrote:

Not seeing scrollbars on prod or staging or local, firefox or chrome.

On Thu, Dec 21, 2023, 8:23 PM Richard Parris @.***> wrote:

Screenshot_2023-12-22-00-18-37-47_e4424258c8b8649f6e67d283a50a2cbc.jpg (view on web) https://github.com/SaitoTech/saito-lite-rust/assets/2867779/0a923c4e-2131-40e2-89ed-bf5c58c8207f

We now have scrollbars everywhere in mobile. Please fix.

— Reply to this email directly, view it on GitHub https://github.com/SaitoTech/saito-lite-rust/issues/2249#issuecomment-1866234513, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ3NQAAGIZ5K6O7J2AZZUQTYKQZ6XAVCNFSM6AAAAABA5VZUB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRWGIZTINJRGM . You are receiving this because you were assigned.Message ID: @.***>