In-game crypto offfer validation

SaitoTech / saito-lite-rust

a version of the Saito-Lite client written for compatibility with the Saito Rust client and binary data format

24 stars 25 forks source link

In-game crypto offfer validation #2451

Closed umairkhannn closed 3 months ago

umairkhannn commented 3 months ago

you cannot enter negative numbers
you cannot enter letters emoji etc
that the numbers entered are sane (not more than 8 significant figures before or after the decimal.
Make the 'Confirm P2P gaming is legal in my jurisdiction option is checked by default.

Screenshot from 2024-04-15 03-18-23

Screenshot from 2024-04-15 03-24-09

arpee commented 3 months ago

Validation should match the send ui. The rules should be enforced on what can be entered into the input...

Right now it is possible to enter non-alpha chars including - these should simply be blocked. As should a second . which should be the only non-numeric character that can be entered.

We should not be validating this with a confirmation.

Similarly it should not be possible to enter more than 10 decimal places or numbers bigger than the max stake available to anyone in the game.

arpee commented 3 months ago

This is looking good though I can still enter - symbols.

Fix that and this is complete.

umairkhannn commented 3 months ago

This is looking good though I can still enter - symbols.

Fix that and this is complete.

Okay got it.