New community css review

joelshu1 commented 3 months ago

OK huge update. I think i've well-preserved existing variables to avoid much issue, but will need to properly test things no matter what.

f8daniel commented 3 months ago

I'm a little confused about the explosion of variable names... like how is a developer supposed to work with this? We can accept these changes, but I'm pretty sure everyone will ignore the 30 different named choices for border-radius, and just pick something (1rem or so) that works for the UI component they are building

joelshu1 commented 3 months ago

Yeah good point. I think there are a few reasons why I did it this way. First was just to pull out as much of the visual control into one place. Second was to be able to have a way for 3rd party theme adjustments (if that could be a thing) or at the very least really easy theme building in the future. And 3, most importantly was to try and reign in some of the design control so that future design somewhat fits into existing guidelines. But yes, this is all a work in progress. I think many of the variables I’ll be able to consolidate as I get a better feel for what is a useful control and what is more of a system control that doesn’t really need user access ever.

As for the likelihood of a dev just going the easy way and picking their own border radius, hopefully there is some move towards more standardization where someone can know that for the element they are working on, they can standardize to border-radius-thin and have results that modified in easy groups later… To be honest, the border radius isn’t the more critical part of this. I think the fonts is where I spent a while thinking. That each theme uses the same language to define font styles and then it is really easy for someone to control all the different elements to use these font styles in a predictable way. Borders and shadows are also really interesting done in this way.

Also beyond consolidating many of these, I’ll spend more time cleaning it up so that it is easier to access. That will help a lot.

On April 17, 2024 at 1:44:14 PM, Daniel Worlton @.***) wrote:

I'm a little confused about the explosion of variable names... like how is a developer supposed to work with this? We can accept these changes, but I'm pretty sure everyone will ignore the 30 different named choices for border-radius, and just pick something (1rem or so) that works for the UI component they are building

— Reply to this email directly, view it on GitHub https://github.com/SaitoTech/saito-lite-rust/pull/2457#issuecomment-2060420728, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW3WNDE5ILFT3B4AE3NQ2FDY5YD25AVCNFSM6AAAAABGKPZYUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQGQZDANZSHA . You are receiving this because you authored the thread.Message ID: @.***>