search

SaitoTech / saito-lite

A cross-platform javascript saito implementation
https://saito.io
58 stars 20 forks source link

<div id="alert-shim"> freezes the game #37

Closed Tuch-o closed 4 years ago

Tuch-o commented 4 years ago

Bugtesting game against myself. Couped Argentina as the US and the game got stuck at this screen: image

The other player sees this tho. The OK button works fine and the game can be continued on his side so it must be an interface bug. image

Took a look at the console and deleted this element: image

Deleting it fixed the issue, game went back to normal and I kept on playing: image

Tuch-o commented 4 years ago

Also happens when the game ends: image

Tuch-o commented 4 years ago

NOTE: Happens after every coup, not specific to Argentina. Refreshing fixes it too.

trevelyan commented 4 years ago

i don't understand what this means.

How to replicate the problem?

On Thu, Feb 20, 2020 at 10:48 PM Tuch-o notifications@github.com wrote:

NOTE: Happens after every coup, not specific to Argentina. Refreshing fixes it too.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SaitoTech/saito-lite/issues/37?email_source=notifications&email_token=AAHAMXYI7L4SLBI6L7QPG5TRD2Q4DA5CNFSM4KEM7IX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMO24AA#issuecomment-589147648, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHAMX6JKNWKKMJ6UYMDQCTRD2Q4DANCNFSM4KEM7IXQ .

Tuch-o commented 4 years ago

I made a gif to better illustrate my point:

coup

After launching a coup, the screen with the results gets covered by a grey overlay that makes the OK button unclickable. There are two ways to fix it: Refreshing the page or opening the console and deleting the div id="alert-shim" element.

trevelyan commented 4 years ago

Ah... I get this.

I think this is something that Richard is probably better off at handling.

On Fri, Feb 21, 2020 at 7:01 AM Tuch-o notifications@github.com wrote:

I made a gif to better illustrate my point:

[image: coup] https://user-images.githubusercontent.com/54612963/74987740-4448fd00-5412-11ea-9aeb-27895c0b5f36.gif

After launching a coup, the screen with the results gets covered by a grey overlay that makes the OK button unclickable. There are two ways to fix it: Refreshing the page or opening the console and deleting the div id="alert-shim" element.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SaitoTech/saito-lite/issues/37?email_source=notifications&email_token=AAHAMXZHUAEJ44M42DPCWDLRD4KTZA5CNFSM4KEM7IX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMRAHHQ#issuecomment-589431710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHAMX3FYTVRIZ26ZEYYGRDRD4KTZANCNFSM4KEM7IXQ .

Tuch-o commented 4 years ago

Fixed, closing.