Change balance limit in issuance mode from preserving balances >25,000 to >=25,000 (it is deleting 25k balances...

SaitoTech / saito-rust-workspace

Cargo workspace which contains all the rust projects for Saito

4 stars 3 forks source link

Closed SankaD closed 1 year ago

arpee commented 1 year ago

I have just tested this and balances of exactly 25000 are being preserved now.

BUT the sub 25,000 balances are not being swept up into the project wallet...

Has that work been finished (i know it was in a PR), and do I have the most recent binary? I got it from the newest build&publish job i could find...

umairkhannn commented 1 year ago

Sharing my findings during testing testing here...

umairkhannn commented 1 year ago

CASE 1: Send Balance greater than 25,000 SAITO

Wallet 1: Initial balance: 140000 SAITO Public key: qxjf4BC2556utVHv2X2uMinHSUyBRCPfRFkTNQdq6Z7j

Wallet 2: Initial balance: 0 SAITO Public key: qqbtLqinhD36YRG9j7q6po9BAeNn9YV2rAsuHVs7SiYd

Project key: Initial balance: 10000000 SAITO Public key: q6TTBeSStCLXEPoS5TUVAxNiGGnRDZQenpvAXXAfTmtA

Steps:

Sending 30000 SAITO from WALLET 1 to WALLET 2
./saito-rust --mode utxo-issuance running with cron job creating issuance file in background.

Result: Balance sent from wallet 1 to wallet 2 without issue and balance also updated in issuance file:

Project key (balance unchanged) 10000000 q6TTBeSStCLXEPoS5TUVAxNiGGnRDZQenpvAXXAfTmtA Normal

Wallet 1 110000 qxjf4BC2556utVHv2X2uMinHSUyBRCPfRFkTNQdq6Z7j Normal

Wallet 2 30000 qqbtLqinhD36YRG9j7q6po9BAeNn9YV2rAsuHVs7SiYd Normal

umairkhannn commented 1 year ago

CASE 2: Send Balance less than 25,000 SAITO

Wallet 1: Initial balance: 110,000 SAITO Public key: qxjf4BC2556utVHv2X2uMinHSUyBRCPfRFkTNQdq6Z7j

Wallet 2: Initial balance: 0 SAITO Public key: uFzdFMQMgCgL9wH6yhUESteB2jat5arZ7QSsJeuswQhN

Project key: Initial balance: 10,000,000 SAITO Public key: q6TTBeSStCLXEPoS5TUVAxNiGGnRDZQenpvAXXAfTmtA

Steps:

Sending 10000 SAITO from WALLET 1 to WALLET 2
./saito-rust --mode utxo-issuance running with cron job creating issuance file in background.

Result: Balance sent from wallet 1 to wallet 2 and balance also updated in issuance file:

Issue: Dust balance 10000 SAITO isnt being added to the project key.

Issuance file balances after transfer: Project key (balance unchanged) 10,000,000 q6TTBeSStCLXEPoS5TUVAxNiGGnRDZQenpvAXXAfTmtA Normal

Wallet 1 100,000 qxjf4BC2556utVHv2X2uMinHSUyBRCPfRFkTNQdq6Z7j Normal

Wallet 2 10,000 qqbtLqinhD36YRG9j7q6po9BAeNn9YV2rAsuHVs7SiYd Normal

umairkhannn commented 1 year ago

After latest push from @davikstone2 i tested it again and confirmed that dust balance is being added to project key on creation of new issuance file.

@SankaD @arpee