Font-Awesome

[trevelyan]

we are remote-loading a library we need to include in-house, at least for chrome extension purposes.

[sebs]

these are on npm, at least the google fonts are.

[escapedcat]

yup, https://github.com/FortAwesome/Font-Awesome

[trevelyan]

Just as a heads up -- it is probably preferable to link directly to libraries hosted as part of the distribution rather than relying on NPM includes. We can always have scripts that swap out those links for CDN materials.

Why? Using NPM-bundled scripts (i.e. socket.io, font-awesome) mean that the scripts are not available when we need to convert the Saito application into javascript. It also requires making more complicated changes to multiple files (HTML as well as JS). The reason for this is that extensions (at least in chrome) can only run javascript that is bundled together with the HTML files that are stored offline. So we need the files locally anyway.

We have the same issue with socket.io FWIW. I'm planning to inline the javascript for that as a default library instead of linking through the NPM module.

On Wed, May 23, 2018 at 4:35 AM, hannes notifications@github.com wrote:

yup, https://github.com/FortAwesome/Font-Awesome

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SaitoTech/saito/issues/9#issuecomment-391266626, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4GXwxoZ1bUA7enMB2JBZoVHfq5AKrMks5t1R9dgaJpZM4UGOJa .

[trevelyan]

This is irrelevant for server-hosted modules, but it will make a difference for any module that needs / wants to have a user-interface, either on a separate webpage or as part of the default email install.

On Wed, May 23, 2018 at 9:06 PM, David Lancashire < david.lancashire@gmail.com> wrote:

Just as a heads up -- it is probably preferable to link directly to libraries hosted as part of the distribution rather than relying on NPM includes. We can always have scripts that swap out those links for CDN materials.

Why? Using NPM-bundled scripts (i.e. socket.io, font-awesome) mean that the scripts are not available when we need to convert the Saito application into javascript. It also requires making more complicated changes to multiple files (HTML as well as JS). The reason for this is that extensions (at least in chrome) can only run javascript that is bundled together with the HTML files that are stored offline. So we need the files locally anyway.

We have the same issue with socket.io FWIW. I'm planning to inline the javascript for that as a default library instead of linking through the NPM module.

On Wed, May 23, 2018 at 4:35 AM, hannes notifications@github.com wrote:

yup, https://github.com/FortAwesome/Font-Awesome

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SaitoTech/saito/issues/9#issuecomment-391266626, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4GXwxoZ1bUA7enMB2JBZoVHfq5AKrMks5t1R9dgaJpZM4UGOJa .

[sebs]

Thanks for the answer. Reasonable ;)