search

SaitoTech / saito

big-data application blockchain
Other
18 stars 17 forks source link

Iran-Iraq War awards extra VP #92

Closed Tuch-o closed 5 years ago

Tuch-o commented 5 years ago

This happens when Flower Power is in affect so I think it's just a thing of Flower Power giving its 2 VP twice

Look at the log here

image

Another Instance:

image

trevelyan commented 5 years ago

We've gone through a long back-and-forth with how to handle Flower Power.

Do we handle them in the cards themselves? Or do we handle it outside?

I've just removed all handling of Flower Power within the card events. So the game engine is checking now. The next update should fix this. It would be good to test that it actually works afterwards, since it will affect ALL war cards.....

Should be live on the server the next time we recompile the code, which will be... tonight?

Will close the bug report then.

Cheers,

--david

On Mon, Oct 21, 2019 at 10:09 PM Tuch-o notifications@github.com wrote:

This happens when Flower Power is in affect so I think it's just a thing of Flower Power giving its 2 VP twice

Look at the log here

[image: image] https://user-images.githubusercontent.com/54612963/67217477-c7b9f980-f3f2-11e9-9897-f64346096fb5.png

Another Instance:

[image: image] https://user-images.githubusercontent.com/54612963/67217543-e4eec800-f3f2-11e9-831e-d531df53e164.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SaitoTech/saito/issues/92?email_source=notifications&email_token=AAHAMX7CSGQMX7JQLLAAS5LQPXA3LA5CNFSM4JC62DA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTGP4KQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHAMX5CV6LDAMASAH34ZYLQPXA3LANCNFSM4JC62DAQ .

trevelyan commented 5 years ago

I believe this is now fixed. Please help keep an eye open for this to confirm, as there are several war cards and Flower Power is a tricky one to fix / code!