SaiyamTuteja / Faculty_Evaluation_System

MIT License
32 stars 45 forks source link

Feat: Toggle View for Password field during signup and login #18

Closed aswinikalyan30 closed 1 month ago

aswinikalyan30 commented 1 month ago

Describe the feature

The field currently shows as password field which can be modified to have a show/hide toggle

Add ScreenShots

image

Record

Arya-Hari commented 1 month ago

Hi! I would love to work on this issue. As per my understanding, the login page has to be modified to include a toggle feature to show and hide the password as necessary by the user. I have worked with HTML, CSS and JS for about a year now and I hope I can make a valid contribution. Thanks!

aindree-2005 commented 1 month ago

@aswinikalyan30 can I please work on this issue?

aswinikalyan30 commented 1 month ago

Hey @aindree-2005 , gotta assign it to @Arya-Hari as she had commented before You can look at the other issues or create one of your own!

Arya-Hari commented 1 month ago

@aswinikalyan30 I have been facing an issue importing the database schema and so i haven't been able to view the pages properly on my local system. I have made some changes to the login page only and created a PR. Kindly let me know if the changes are proper, only then will I proceed for the signup page. Sorry for the hinderance :(

aswinikalyan30 commented 1 month ago

No worries @Arya-Hari , let me know if you need help setting up , we can connect over discord. The readme is still getting prepared so it is quite confusing. I will review the changes by pulling them to my local setup.

sk-upadhyay commented 1 month ago

@aswinikalyan30 i have done changes accept it going to do more

aswinikalyan30 commented 1 month ago

No @sk-upadhyay that's not how it works. You first get assigned an issue and then raise a PR. @Arya-Hari is already working on this. Do whatever is assigned to you

sk-upadhyay commented 1 month ago

@aswinikalyan30 can you add me as reviewer in this

Arya-Hari commented 1 month ago

@aswinikalyan30 I'm so sorry but I've been having issues all week with my laptop and am not able to run any medium or heavy duty applications...I haven't been able to make any changes and I don't think I'll be able to for a few more days. Since I don't want to keep this issue open and since there are other interested contributors for these issues, I'm okay with this issue and the other being reassigned to some other contributor. Once again, sorry for the delay

sk-upadhyay commented 1 month ago

@aswinikalyan30 assign me and merge my code

aswinikalyan30 commented 1 month ago

Sure @Arya-Hari . Thanks for letting me know

sk-upadhyay commented 1 month ago

@aswinikalyan30 As my previous code has solved the issue so you can close this issue