SaiyamTuteja / Faculty_Evaluation_System

MIT License
32 stars 45 forks source link

Feat: Filter genuine email #21 #40

Closed sk-upadhyay closed 1 month ago

sk-upadhyay commented 1 month ago

PR Description

Integrated disify api for filtering out disposable email by verify_email Removed data redundancy by implementing cuid to be assigned to only one person
changes need to be done in SQL is to make CUID as primary key and remove index as primary key

Related Issues: Issue for which you are raising a PR for

Issue #21

[Issue number or description]

Checklist

Undertaking

I declare that:

  1. The content I am submitting is original and has not been plagiarized.
  2. No portion of the work has been copied from any other source without proper attribution.
  3. The work has been checked for plagiarism, and I assure its authenticity.

I understand that any violation of this undertaking may have legal consequences that I will bear and could result in the withdrawal of any recognition associated with the work.

sk-upadhyay commented 1 month ago

@aswinikalyan30 Any Update on my PR

aswinikalyan30 commented 1 month ago

Hey. This has changes that solves an issue not assigned to you

sk-upadhyay commented 1 month ago

@aswinikalyan30 so what should i do?? should i update and pr again or i should close it.

sk-upadhyay commented 1 month ago

@SaiyamTuteja Can you merge my PR as it is approved