search

Saiyato / volumio-rotary-encoder-plugin

Simple dual rotary encoder plugin for Volumio 2.x
MIT License
19 stars 6 forks source link

few changes to plugin #3

Closed diehardsk closed 6 years ago

diehardsk commented 6 years ago

Hello. I'd like to contribute to this great plugin. My opinion is, there's always only gray coding for two-signal rotary encoder. So I suggest to use single processing. Encoder type setting now lets you select how many steps are considered as movement. (4 or 1) Do you agree with that? Originaly there was lot of random stuff happening while using basic cheap rotary encoder (even with 100n caps). Now it's perfectly reliable. The only problem I see is that it takes too long time for volumio to make action. I expected volume change to be a bit faster. But I know that is not problem of plugin. I will use it for navigation in playlist. And despite the fact I'm beginer in java coding, I've managed to add hw interrupt detach function when configuration is changed. No need to reboot each time. Thank you for your time and effort you spend with plugin.

Saiyato commented 6 years ago

Hi,

Thanks for the feedback and suggestions, will try to test everything today so I can PR them to the Volumio repo. Awesome work! I'm not so much a java(script) developer, so many functions like destroy are pretty new to me, but they do help. Thanks again.

Cheers

Saiyato commented 6 years ago

It appears to be working just fine, great job! Thanks.

diehardsk commented 6 years ago

I'm glad to hear that. Thanks!