search

SakshamAgrwl / GFG-DSA-Problem-Solutions

Celebrate Hacktoberfest by getting involved in the open source community by completing some simple tasks in this project.
18 stars 38 forks source link

Creating function to find PerimeterOfRectangle #46

Closed rishikasoni67 closed 4 years ago

SakshamAgrwl commented 4 years ago

@rishikasoni67 Please star this repo, the star symbol can be found beside the fork symbol.

rishikasoni67 commented 4 years ago

Sure . One request, if you could label this as hactoberfect-acepted

SakshamAgrwl commented 4 years ago

I have labelled it as hacktoberfest. Don't know how to label as hacktoberfest-accepted. If you know this then open this issue and start solving this issue or just create a new issue related to this and somebody will do it.

SakshamAgrwl commented 4 years ago

@rishikasoni67 Please do let me know now if you can view the hacktoberfest-label and if your PR is accepted now.

rishikasoni67 commented 4 years ago

Yes, I can view the label now. Thank you .. @SakshamAgrwl

SakshamAgrwl commented 4 years ago

@rishikasoni67 I would like to know if your PR is accepted for hacktoberfest or not.

rishikasoni67 commented 4 years ago

@SakshamAgrwl I am new to Hactoberfest and even created PRs for the first time and simply just know that after being merged or labeled as hactoberfest-accepted, PRs are accepted for Hactoberfest. Moreover, after passing the review period of 14 days this will be accepted and a tick ✔️ will be shown on my Hactoberfest profile.

SakshamAgrwl commented 4 years ago

@rishikasoni67 Yes, you are correct, I'm updating the readme.md file to make it more friendly for the new comers which makes it easy for anyone to create a new PR. Feel free to create issues for this repo so that many people can work on those issues.

rishikasoni67 commented 4 years ago

@SakshamAgrwl 👍

SakshamAgrwl commented 4 years ago

Hey @rishikasoni67 i have updated the readme file of this repository. Go ahead and view it and you will get more familiar to this repo. Also, please start creating new issues for this repo.