search

Sakura-IT / SonnetAmiga

Reimplementation of WarpOS supporting Sonnet Crescendo 7200 and other PowerPC PCI cards (mirror of CVS development repository).
MIT License
39 stars 3 forks source link

Dependency on DevPac system library. #19

Closed rkujawa closed 8 years ago

rkujawa commented 8 years ago

I wanted to plug InitSonnet into our build system. Basically I've done the necessary adjustments, but do we really need that DevPac system library? It makes requirements on external stuff even more complex than it already is. If possible, I'd like to keep them at minimum. What does InitSonnet really use that is there? Can we just copy^Wreimplement the necessary routines and put them in our tree?

DvdBoon commented 8 years ago

I use system.gs (which is just a big table made of all the common NDK includes) because it saves me from finding out which includes to use separately (a.k.a. lazy). I fixed the source, though. Could you check it out if it compiles?

rkujawa commented 8 years ago

I had to make a few minor changes related to includes. See 84b6c72fbbfff2359bf86f84268d7fb9382d90bf. Shouldn't sonnet_lib.i be moved to common directory in this case? Or sonnetlib added to -I flag when assembling?

The rest is just boring Makefile cruft. It does compile now as a part of standard build.

DvdBoon commented 8 years ago

If you want it to be in-line with the assembling of the library then please add common to the -I flag. I kept it the same as with sonnet.s. Or did we change that somewhere in the past?

DvdBoon commented 8 years ago

Oops, I now see what you mean. Maybe move all this stuff to common?

rkujawa commented 8 years ago

If by this stuff you mean the .i files, then I think it's probably a good idea. Please do.

I'll adjust the Makefiles if necessary. Although it should just work since -I passed when building InitSonnet already includes common directory. It might break somewhere else though. Guess we won't know until we try :stuck_out_tongue: .

DvdBoon commented 8 years ago

Moved it. Probably breaks the library itself.

DvdBoon commented 8 years ago

Oooh, quite the spectacular breakage :-P

rkujawa commented 8 years ago

Even I am not sure why make suddenly wanted to call as instead of vasm. Anyway I fixed it and committed just now. If the next build passes, it means it's OK.

rkujawa commented 8 years ago

Looks like it's OK. I'm closing this.