search

Sala7din / BJJ-Competition-Weight-Checker

BJJ competition weight checker app
2 stars 0 forks source link

replace icons with suitable icons by using a CDN #1

Open Sala7din opened 1 year ago

Sala7din commented 1 year ago 
// TODO: replace icons with suitable icons by using a CDN

https://github.com/Sala7din/BJJ-WeightClass-Calculator/blob/c7cd65288f995189b773d01673793923ef105faa/src/components/TheWelcome.vue#L2

pascalwengerter commented 1 year ago

My advise would be not to bother with a CDN here - putting the icons you like&choose in src/assets/icons should be fine, since this (at least for quite a while) will not be a large website with potentially hundreds (or thousands) of icons and pages.

What I can recommend is this library, which requires attribution (see Musclemate's about page for an example):

pascalwengerter commented 1 year ago

A CDN is a powerful tool and has its place, but might be adding more complexity than benefits at this stage

Sala7din commented 1 year ago

Thank you for your suggestion! I actually already used the library from https://github.com/Templarian/MaterialDesign, but I appreciate your recommendation of game-icons.net. After looking at the icons available, I agree that they are more suitable for the project. Thanks again for your help!