search

SaladDais / Hippolyzer

Intercepting proxy + analysis toolkit for Second Life compatible virtual worlds
GNU Lesser General Public License v3.0
13 stars 5 forks source link

Probable bug in Circuit InjectionTracker's drop tracking #10

Closed SaladDais closed 2 years ago

SaladDais commented 3 years ago 
Attempting to re-send previously dropped 1523:AgentUpdate, did we ack?
Attempting to re-send previously dropped 1607:ViewerEffect, did we ack?
Attempting to re-send previously dropped 1720:ViewerEffect, did we ack?

https://github.com/SaladDais/Hippolyzer/blob/a1bbfbf4103dff7a955c060824a4ae29e753ac3d/hippolyzer/lib/proxy/circuit.py#L75

Nothing should have dropped packets of those types, so packet IDs must be getting re-used. Likely packet IDs are getting out of sync somewhere and making the proxy think there's a resend happening.

First noticed this when using the turbo object inventory addon, so it's possible there's some faulty logic in message.take() or MessageHandler subscription stuff too.

SaladDais commented 2 years ago

Haven't seen one of these in a long time, seems to be fixed.