search

Salamafet / ophom

Octoprint Philips Hue Outlet Manager
7 stars 1 forks source link

Disconnect Printer Before Shutdown? #36

Closed James-Coyne closed 3 years ago

James-Coyne commented 3 years ago

To avoid inaccurate errors in cases where Octoprint remains live while the printer turns off, it would be nice if Ophom told Octoprint to disconnect from the printer before shutting off the plug powering it. Could this feature be added?

Salamafet commented 3 years ago

I can add this function but what kind of error are you talking about ? In my case Octoprint still live every time and I have encountered no error.

James-Coyne commented 3 years ago

Octoprint will report a connection timeout error when the plug and printer are shut off. Other plugins that monitor prints and send messages to external services can also interpret this as a failure.

Salamafet commented 3 years ago

This is a good reason 👍

I add this to my todo.

Salamafet commented 3 years ago

Done !

USB is now correctly disconnected before shutdown. Reopen this issue if you have any problem with this update.

And sorry for the delay.