search

Salamafet / ophom

Octoprint Philips Hue Outlet Manager
8 stars 1 forks source link

"Plug" button in the top menu looks clickable, but seems to do nothing #5

Closed MPFGlaser closed 4 years ago

MPFGlaser commented 4 years ago

When hovering the cursor over the "plug" icon in the top menu bar the background changes colour as if it is a functional button. However, the cursor itself does not change from an arrow to a click-hand. While I'm not sure if this is a bug or an (attempted) unintended use of the icon, my first instinct would be to click the plug to turn the Hue plug/printer on while it is in the "off" state. Using version 1.1.0 of OPHOM and version 1.4.2 of Octoprint

Salamafet commented 4 years ago

I will fix that as soon as possible

Thanks

Salamafet commented 4 years ago

Fixed in https://github.com/Salamafet/ophom/pull/7 !

Update and go back to me if the problem persist.

MPFGlaser commented 4 years ago

Thanks for the quick fix! The cursor now seems to behave as expected, as well as the on/off button while the printer/plug is already on. Clicking it then turns the plug off, as expected. However, strangely enough, clicking the button while the printer/plug is off still does not turn the plug on as expected.

Salamafet commented 4 years ago

Oh... this is not normal. I don't have understand that in your first message, sorry.

Which browser do you use ?

MPFGlaser commented 4 years ago

Don't worry! It might not have been the smartest move of mine to describe two bugs (although related) at once. I use Chrome Version 84.0.4147.135 (64-bit) but the issue also occurs in the latest version of Edge. It doesn't work on Mobile (Android 10, Chrome 84.0.4147.125), either. I don't think it would matter because the protocol is the same, but I'm using the Hue Bridge 2.0 (the square one).

Salamafet commented 4 years ago

I have the same bridge.

Can you send me the network request response when you click on the On/Off button. Developer console -> Network (F12)

I don't know if you are comfortable with web request/API but you can normally see a request to http://<octoprint_ip>/api/plugin/ophom?action=toggle

This this the same request for turning On or Off the plug. In a normal way, the request return 0 if the plug is powering Off and 1 if the plug is powering On.

Can you test this for me ?

MPFGlaser commented 4 years ago

Strangely enough, after more than a dozen restarts while installing OctoKlipper/Klipper on my machine, the button magically started working again. Apologies for the inconvenience, as I think it was just user error. (seeing as I still use the same version)

Salamafet commented 4 years ago

Good news. Thanks for your feedback. At least you pointed a bug with the navbar.

If the problem appear again, come back to me.

Salamafet commented 4 years ago

I find the bug ! I have the same one.

Yesterday I have push an update to alert the user if he try to power off the plug when a printing is running. This is the problem. I'm working on it.

Salamafet commented 4 years ago

Ok if you update the bug is normally fixed

Sorry for that