search

Salamek / PplMyApi

Professional Parcel Logistic MyApi PHP client implementation with PDF and ZPL label generator
GNU Lesser General Public License v3.0
27 stars 34 forks source link

[WIP] Fixes #35

Closed mirekratman closed 6 years ago

Salamek commented 6 years ago

@mirekratman i quess that this is still WIP ? if so just prefix PR name with [WIP] and remove this prefix when you think that PR is ready for merge ;-) GW

mirekratman commented 6 years ago

Hi, localy all test are passed, just scruntizer fails - will check it.

Salamek commented 6 years ago

@mirekratman HI, how it looks with this PR ? I'm getting requests to implement GetNumberRange... and that is implemented in this PR. Do you need some help to finish this PR ?

mirekratman commented 6 years ago

@Salamek Hi, How fast you need this? I will be unavailable for a week from today. When I will be back i will finish it. The only reason why its not done is the fact it fails on Travis. The code itself should be fine.

Salamek commented 6 years ago

@mirekratman well i think it can wait a while... Or i may merge it as is and fix travis issues my self (if i get to it before you do). So have a nice ?vacation? i guess :smiley:

mirekratman commented 6 years ago

@Salamek ... yes you can. For me no problem. As you can see there is also unit test for this and it passes correctly.