search

Salamek / PplMyApi

Professional Parcel Logistic MyApi PHP client implementation with PDF and ZPL label generator
GNU Lesser General Public License v3.0
27 stars 34 forks source link

Incorrect WeightedPackageInfo parameter name #71

Closed david-vaclavek closed 2 years ago

david-vaclavek commented 2 years ago

I'm using v1.3.3 for project compatibility reasons (can't use the newest version, don't have the PHP v7 support), anyway as a browse the code, the problem occurs in the newest version as well.

In Api.php file on line 475, key name should be WeightedPackageInfo instead of WeightedPackageInfoIn. I've checked it against the current WSDL version.

Currently, the WeightedPackageInfo is not sent to API at all. When I changed it manually in my project, it worked.

Would it be possible to update the file?

Thank you.

Salamek commented 2 years ago

That means that wsdl spec was changed... fixed in next release... PS: Also i would suggest to migrate your project to 7.4 (Debian stable PHP version) anything under version 7 is dead, PHP 8.1 is stable version now...

david-vaclavek commented 2 years ago

Thanks.

I know anything under v7 is dead, but I'm just partly contributing to a project and I won't be able to persuade the owner to migrate.

Are you planning to release a patch for the package with v5 support? Or should I make a PR?

Salamek commented 2 years ago

You are still using 1.3.3? That is still working? So if i will branch of 1.3.3 and release 1.3.4 will that be ok for you?

Salamek commented 2 years ago

Ok version 1.3.4 should be installable now...

david-vaclavek commented 2 years ago

Really appreciated.

Thank you for doing that!

PS: Yes, generally PHP v5 version still works well.