search

Salamek / PplMyApi

Professional Parcel Logistic MyApi PHP client implementation with PDF and ZPL label generator
GNU Lesser General Public License v3.0
27 stars 34 forks source link

DepoCode need update request #72

Closed dariuszrup closed 2 years ago

dariuszrup commented 2 years ago

DepoCode need update request. Currently the system only supports ranges 1 to 24. Request to add support for the following: 41, 44, 46, 48, 61, 62, 65, 66, 67, 96, 98, T2 or rework the setDepoCode method so that it does not throw exception

Salamek commented 2 years ago

@dariuszrup is there any official source for these depo codes?

dariuszrup commented 2 years ago

Yes, please see what official information I got from PPL:

"From the error I think that there is trouble with wrong mapping of depocodes. I see that there is used part of basic code from GitHub developer Salamek. This person is doing theyr own solution which is not approved from PPL and theyr solution has some errors. This looks like one of them.

Salamek has own script for label creating and this error reflect incomplete list of depo codes, because we are depoCode with values which is written but there are missing another one like 41, 44, 46, 48, 61, 62, 65, 66, 67, 96, 98, T2

In this case there is need to do some modification of code, or add depots for list. I'm sorry but I don't know where and what to do because this is not our product and person Salamek is not cooperate with our company.

Thank you for your understanding"

Salamek commented 2 years ago

@dariuszrup should be fixed in 2.5.2

PS: Also it is "nice" to read how PPL staff is throwing blame to my direction...while i maintain a PHP library for them for free...without any support from them... :disappointed:

In this case there is need to do some modification of code, or add depots for list. I'm sorry but I don't know where and what to do because this is not our product and person Salamek is not cooperate with our company.

They know very well where to reach me, they know that this project exists and there is my email right on my profile if they want some private communication... also i have asked them about cooperation and they did not respond, you can see that in https://github.com/Salamek/PplMyApi/issues/62#issuecomment-1045211901

dariuszrup commented 2 years ago

Oki thank you for your reply. I can prepare a proposal to fix the code tomorrow

dariuszrup commented 2 years ago

oki I see you already added the fix -> thanks