Salamek / cron-descriptor

A Python library that converts cron expressions into human readable strings.
MIT License
160 stars 38 forks source link

Add handling for 7=Sunday (e.g., "* * * * 7") #52

Closed cuu508 closed 2 years ago

cuu508 commented 1 year ago

Hey @Salamek, I'm considering doing a few more PRs for cron-descriptor. Since this PR was closed, before I go ahead, I'd like to know:

Thanks!

Salamek commented 1 year ago

Hi @cuu508 This PR was closed since this issue was solved in https://github.com/Salamek/cron-descriptor/commit/0305fbcb8c150ff1fcf7ad87317d7f152da49aba (normalization of DoW in ExpressionParser.py that is in line with https://github.com/bradymholt/cron-expression-descriptor i forgot to mention it here)

And Q/A:

Do you accept PRs that add new features?

Yes i do.

Do you accept PRs that fix output bugs (a cron expression gets converted to a nonsensical human-language description)?

Yes but they need to not break other languages translations (it is not in my capacity to translate/fix other languages then EN/CS/SK)

Or do you only accept housekeeping PRs, and keep the logic in line with https://github.com/bradymholt/cron-expression-descriptor?

Well i'm kinda trying to use same logic as in https://github.com/bradymholt/cron-expression-descriptor (it makes maintaining this library simpler) but i have no problem to deviate when it makes sense. I actually have some changes planed my self if i ever find a time for them :-) (Like some code cleanup, drop StringBuilder.py, rework i18n a bit, "Pythonize" Options.py [just drop it and use kwargs], add meaningful exceptions everywhere when CRON expression is invalid etc...