search

Salamek / gitlab-tools

Web application providing tools not avaiable in GitLab CE (Gitlab push/pull mirror and more)
GNU General Public License v3.0
99 stars 15 forks source link

add docker setup and pin some dependencies #34

Closed cenk1cenk2 closed 2 years ago

cenk1cenk2 commented 2 years ago

Hey @Salamek,

I have added a docker container as discussed on #5. To enable doing that I had to pin some dependency versions but no matter what I have tried I have failed to run this in a container otherwise. pycrypto was also one of them, as mentioned on issue #31 it worked with a direct replacement of pycryptodom. Please tell me if I am missing something as in the case of dependencies.

The container runs the API, Celery controller, and Celery Background task inside one container. RabbitMQ and Redis are also integrated into the container itself since they have no configuration to point to external servers. But for the scale of the application, I guess it is not that important, so I did not extend the config and this MR. The API is being run through the UWSGI socket to the Nginx socket as suggested. Everything runs on an unprivileged user account as suggested.

With this pull request:

Salamek commented 2 years ago

Hi, i did bunch of refactoring to use more sane deps and to be compatible with Debian 11, so if you can modify your PR to reflect this

cenk1cenk2 commented 2 years ago

Hey @Salamek ,

Thank you for your work on this again! I have updated the container accordingly and moved it to Debian 11 Bullseye.

I still encountered one little problem with the jinja version flask uses and markupsafe. But pinning the version of markupsafe safe solves it. Hope it is an acceptable solution. Also, latest jquery that was updated by Dependabot was not acting right with the given version of bootstrap so I had to also revert it back to 3.4.1.

Everything works a charm now. I will change the docker configuration to point to this repository with a specific commit if you accept my changes.

Salamek commented 2 years ago

Looks good to me!, Merging....

Salamek commented 2 years ago

Oh also in your README.md

Due to complications, this application runs on an old version of Debian and Python, but it should cause no problems since this application is designed with it.

This^ no longer applies i think...

cenk1cenk2 commented 2 years ago

Thanks for your time on this maintaining this again Salamek. I have updated the README accordingly.