search

Salamek / gitlab-tools

Web application providing tools not avaiable in GitLab CE (Gitlab push/pull mirror and more)
GNU General Public License v3.0
99 stars 15 forks source link

fix(db): update online migrations #49

Closed cenk1cenk2 closed 3 months ago

cenk1cenk2 commented 3 months ago

Hello again @Salamek,

I have tried to upgrade the version of the docker container that I created out of your application as you are aware of at here.

I encountered a problem while trying to run the migrations manually with manage.py db migrate and manage.py db stamp as you have described.

As it turns out while running the online migrations while trying to configure alembic.context, compare_types is defined twice as an argument, one explicitly and one I think from current_app.extensions['migrate'].configure_args and it was causing a panic .

Therefore, I would submit this PR for your review if it has no destructive changes, this change fixes the flow of the container, elsewise I can adapt it accordingly.

cenk1cenk2 commented 3 months ago

As always thank you for your time maintaining this project.