Update dialup profile - Githubissues

timvlaer commented 4 months ago

While working on the api for dialup profiles, I noticed a few things:

it looks like you can't really control the behaviour of SetDefault when creating a profile. It looks like newly created profiles always become the default, irregardless of the SetDefault parameter value. I removed the parameter from the function.
When creating a profile without dialup_number (DialupNum), the request failed with error 100001. It looks to me that this field is not optional in my setup... I didn't change this in the code as the example script doesn't have this param so I guess it might work in some cases without dialup_number.
FYI, I couldn't remove the default profile, which has the ReadOnly set to 2 (instead of 0 for manually created profiles)

I tested these things against the api of the Huawei E5576-320, so it might be different on other devices.

Salamek commented 4 months ago

@timvlaer ping

timvlaer commented 4 months ago

@Salamek this pr is ready for review. I don’t plan any additions.

Salamek commented 4 months ago

@timvlaer ah sorry my bad, i did not post the review...

timvlaer commented 4 months ago

My apologies, i am abroad right now without computer so I’ll update this PR as soon as i am back home. That will be the 19th of August.

Salamek commented 4 months ago

@timvlaer that is completely fine ;-) Enjoy your self.

timvlaer commented 3 months ago

Reverted the is_default param

Salamek / huawei-lte-api